Skip to content

Commit 6678f89

Browse files
authored
feat(deps): apply v4 updates (#88)
* feat(deps): apply v4 updates * [cleanup] add back missed storybook type pkgs * [cleanup] make storybook work again
1 parent e58f67c commit 6678f89

File tree

8 files changed

+5188
-3854
lines changed

8 files changed

+5188
-3854
lines changed

.storybook/webpack.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ const path = require('path');
22
const TsconfigPathsPlugin = require('tsconfig-paths-webpack-plugin');
33
const appConfig = require('../webpack.common');
44

5-
module.exports = ({ config }) => {
5+
module.exports = ({ config, mode }) => {
66
config.module.rules = [];
7-
config.module.rules.push(...appConfig.module.rules);
7+
config.module.rules.push(...appConfig(mode).module.rules);
88
config.module.rules.push({
99
test: /\.css$/,
1010
include: [

README.md

Lines changed: 28 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -4,46 +4,47 @@ Patternfly Seed is an open source build scaffolding utility for web apps. The pr
44

55
Out of the box you'll get an app layout with chrome (header/sidebar), routing, build pipeline, test suite, and some code quality tools. Basically, all the essentials.
66

7-
<img width="1058" alt="Out of box dashboard view of patternfly seed" src="https://user-images.githubusercontent.com/5942899/62715686-fa954980-b9ce-11e9-9fc2-217b7a4d1d81.png">
7+
<img width="1058" alt="Out of box dashboard view of patternfly seed" src="https://user-images.githubusercontent.com/5942899/82119580-b4cf9380-974d-11ea-9f13-fa10471c5c73.png">
88

99
## Quick-start
10+
1011
```bash
11-
git clone https://github.com/patternfly/patternfly-react-seed # clone the project
12-
cd patternfly-react-seed # navigate into the project directory
13-
npm install # install patternfly-react-seed dependencies
14-
npm run start:dev # start the development server
12+
git clone https://github.com/patternfly/patternfly-react-seed
13+
cd patternfly-react-seed
14+
npm install && npm run start:dev
1515
```
1616
## Development Scripts
17+
```sh
18+
# Install development/build dependencies
19+
npm install
1720

18-
Install development/build dependencies
19-
`npm install`
20-
21-
Start the development server
22-
`npm run start:dev`
21+
# Start the development server
22+
npm run start:dev
2323

24-
Run a production build (outputs to "dist" dir)
25-
`npm run build`
24+
# Run a production build (outputs to "dist" dir)
25+
npm run build
2626

27-
Run the test suite
28-
`npm run test`
27+
# Run the test suite
28+
npm run test
2929

30-
Run the linter
31-
`npm run lint`
30+
# Run the linter
31+
npm run lint
3232

33-
Run the code formatter
34-
`npm run format`
33+
# Run the code formatter
34+
npm run format
3535

36-
Launch a tool to inspect the bundle size
37-
`npm run bundle-profile:analyze`
36+
# Launch a tool to inspect the bundle size
37+
npm run bundle-profile:analyze
3838

39-
Start the express server (run a production build first)
40-
`npm run start`
39+
# Start the express server (run a production build first)
40+
npm run start
4141

42-
Start storybook component explorer
43-
`npm run storybook`
42+
# Start storybook component explorer
43+
npm run storybook
4444

45-
Build storybook component explorer as standalone app (outputs to "storybook-static" dir)
46-
`npm run build:storybook`
45+
# Build storybook component explorer as standalone app (outputs to "storybook-static" dir)
46+
npm run build:storybook
47+
```
4748

4849
## Configurations
4950
* [TypeScript Config](./tsconfig.json)
@@ -53,7 +54,7 @@ Build storybook component explorer as standalone app (outputs to "storybook-stat
5354

5455
## Raster Image Support
5556

56-
To use an image asset that's shipped with patternfly core, you'll prefix the paths with "@assets". `@assets` is an alias for the patternfly assets directory in node_modules.
57+
To use an image asset that's shipped with PatternFly core, you'll prefix the paths with "@assets". `@assets` is an alias for the PatternFly assets directory in node_modules.
5758

5859
For example:
5960
```js

0 commit comments

Comments
 (0)