Merge pull request #109 from SpyTec/fix/hot-loader

fix: move @hot-loader/react-dom to dev webpack

Author: redallen

package-lock.json

@@ -11,7 +11,7 @@
     "dr:surge": "node dr-surge.js",
     "build": "webpack --config webpack.prod.js && npm run dr:surge",
     "start": "sirv dist --cors --single --host --port 8080",
-    "start:dev": "webpack serve --hot --color --progress --config webpack.dev.js",
+    "start:dev": "webpack serve --color --progress --config webpack.dev.js",
     "test": "jest --watch",
     "test:coverage": "jest --coverage",
     "eslint": "eslint --ext .tsx,.js ./src/",
@@ -58,7 +58,6 @@
     "raw-loader": "^4.0.2",
     "react-axe": "^3.5.4",
     "react-docgen-typescript-loader": "^3.7.2",
-    "react-hot-loader": "^4.13.0",
     "react-router-dom": "^5.2.0",
     "regenerator-runtime": "^0.13.7",
     "rimraf": "^3.0.2",
@@ -78,7 +77,6 @@
     "webpack-merge": "^5.7.3"
   },
   "dependencies": {
-    "@hot-loader/react-dom": "^17.0.1",
     "@patternfly/react-core": "^4.84.4",
     "@patternfly/react-icons": "^4.7.22",
     "@patternfly/react-styles": "^4.7.22",

package.json

@@ -1,5 +1,4 @@
 import * as React from 'react';
-import { hot } from 'react-hot-loader/root';
 import { CubesIcon } from '@patternfly/react-icons';
 import {
   PageSection,
@@ -40,5 +39,4 @@ let Support: React.FunctionComponent<ISupportProps> = () => (
   </PageSection>
 )
 
-Support = hot(Support); // enable HMR for this async module
 export { Support };

src/app/Support/Support.tsx

@@ -1,4 +1,3 @@
-import { hot } from 'react-hot-loader/root';
 import * as React from 'react';
 import '@patternfly/react-core/dist/styles/base.css';
 import { BrowserRouter as Router } from 'react-router-dom';
@@ -14,4 +13,4 @@ const App: React.FunctionComponent = () => (
   </Router>
 );
 
-export default hot(App);
+export default App;

src/app/index.tsx

@@ -8,9 +8,6 @@ const ASSET_PATH = process.env.ASSET_PATH || '/';
 module.exports = env => {
 
   return {
-    entry: {
-      app: ['react-hot-loader/patch', path.resolve(__dirname, 'src', 'index.tsx')]
-    },
     module: {
       rules: [
         {
@@ -130,9 +127,6 @@ module.exports = env => {
       })
     ],
     resolve: {
-      alias: {
-        'react-dom': '@hot-loader/react-dom',
-      },
       extensions: ['.js', '.ts', '.tsx', '.jsx'],
       plugins: [
         new TsconfigPathsPlugin({

webpack.common.js

@@ -15,7 +15,6 @@ module.exports = merge(common('development'), {
     compress: true,
     inline: true,
     historyApiFallback: true,
-    hot: true,
     overlay: true,
     open: true
   },