Skip to content

Commit e8cf7aa

Browse files
mfrances17mfrances17
committed
chore(Toolbar): add different gap props to examples
1 parent edc04fa commit e8cf7aa

File tree

2 files changed

+233
-15
lines changed

2 files changed

+233
-15
lines changed

‎packages/react-core/src/components/Toolbar/examples/Toolbar.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Note: This example does not demonstrate responsive toolbar behavior. Responsive
2828

2929
You may adjust the space between toolbar items to arrange them into groups. Read our spacers documentation to learn more about using spacers.
3030

31-
Items are spaced “16px” apart by default via their parents' `gap` or `columnGap` property. You can set the property values at multiple breakpoints, including "default", "md", "lg", "xl", and "2xl".
31+
Items are spaced “16px” apart by default and can be modified by changing their or their parents' `gap`, `columnGap`, and `rowGap` properties. You can set the property values at multiple breakpoints, including "default", "md", "lg", "xl", and "2xl".
3232

3333
```ts file="./ToolbarSpacers.tsx"
3434

‎packages/react-core/src/components/Toolbar/examples/ToolbarSpacers.tsx‎

Lines changed: 232 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,46 +3,264 @@ import { Toolbar, ToolbarItem, ToolbarGroup, ToolbarContent } from '@patternfly/
33
import { Button } from '@patternfly/react-core';
44

55
export const ToolbarSpacers: React.FunctionComponent = () => {
6-
const items = (
6+
const groupGapItems = (
77
<React.Fragment>
88
<ToolbarGroup variant="action-group">
99
<ToolbarItem>
10-
<Button variant="secondary">Action</Button>
10+
<Button variant="secondary">Default Gap</Button>
1111
</ToolbarItem>
1212
<ToolbarItem>
13-
<Button variant="secondary">Action</Button>
13+
<Button variant="secondary">Default Gap</Button>
1414
</ToolbarItem>
15+
</ToolbarGroup>
16+
<ToolbarItem variant="separator"></ToolbarItem>
17+
<ToolbarGroup variant="action-group" gap={{ default: 'gapNone' }}>
1518
<ToolbarItem>
16-
<Button variant="secondary">Action</Button>
19+
<Button variant="secondary">No Gap</Button>
1720
</ToolbarItem>
1821
<ToolbarItem>
19-
<Button variant="secondary">Action</Button>
22+
<Button variant="secondary">No Gap</Button>
2023
</ToolbarItem>
2124
</ToolbarGroup>
2225
<ToolbarItem variant="separator"></ToolbarItem>
23-
<ToolbarGroup variant="action-group" gap={{ lg: 'gapSm' }}>
26+
<ToolbarGroup variant="action-group" gap={{ default: 'gapSm' }}>
2427
<ToolbarItem>
25-
<Button variant="secondary">Action</Button>
28+
<Button variant="secondary">Small Gap</Button>
2629
</ToolbarItem>
2730
<ToolbarItem>
28-
<Button variant="primary">Action</Button>
31+
<Button variant="secondary">Small Gap</Button>
2932
</ToolbarItem>
3033
</ToolbarGroup>
3134
<ToolbarItem variant="separator"></ToolbarItem>
32-
<ToolbarGroup variant="action-group" gap={{ lg: 'gapLg' }}>
35+
<ToolbarGroup variant="action-group" gap={{ default: 'gapXl' }}>
36+
<ToolbarItem>
37+
<Button variant="secondary">Extra Large Gap</Button>
38+
</ToolbarItem>
39+
<ToolbarItem>
40+
<Button variant="secondary">Extra Large Gap</Button>
41+
</ToolbarItem>
42+
</ToolbarGroup>
43+
</React.Fragment>
44+
);
45+
46+
const groupColumnGapItems = (
47+
<React.Fragment>
48+
<ToolbarGroup variant="action-group" columnGap={{ default: 'columnGapNone' }}>
49+
<ToolbarItem className="pf-m-wrap">
50+
<Button variant="secondary">No Column Gap</Button>
51+
</ToolbarItem>
52+
<ToolbarItem>
53+
<Button variant="secondary">No Column Gap</Button>
54+
</ToolbarItem>
55+
</ToolbarGroup>
56+
<ToolbarItem variant="separator"></ToolbarItem>
57+
<ToolbarGroup variant="action-group" columnGap={{ default: 'columnGapSm' }}>
58+
<ToolbarItem className="pf-m-wrap">
59+
<Button variant="secondary">Small Column Gap</Button>
60+
</ToolbarItem>
61+
<ToolbarItem>
62+
<Button variant="secondary">Small Column Gap</Button>
63+
</ToolbarItem>
64+
</ToolbarGroup>
65+
<ToolbarItem variant="separator"></ToolbarItem>
66+
<ToolbarGroup variant="action-group" columnGap={{ default: 'columnGapXl' }}>
67+
<ToolbarItem className="pf-m-wrap">
68+
<Button variant="secondary">Extra Large Column Gap</Button>
69+
</ToolbarItem>
70+
<ToolbarItem>
71+
<Button variant="secondary">Extra Large Column Gap</Button>
72+
</ToolbarItem>
73+
</ToolbarGroup>
74+
</React.Fragment>
75+
);
76+
77+
const groupRowGapItems = (
78+
<React.Fragment>
79+
<ToolbarGroup className="pf-m-wrap" variant="action-group" rowGap={{ default: 'rowGapNone' }}>
80+
<ToolbarItem>
81+
<Button variant="secondary">No Row Gap</Button>
82+
</ToolbarItem>
83+
<ToolbarItem>
84+
<Button variant="secondary">No Row Gap</Button>
85+
</ToolbarItem>
86+
<ToolbarItem>
87+
<Button variant="secondary">No Row Gap</Button>
88+
</ToolbarItem>
89+
<ToolbarItem>
90+
<Button variant="secondary">No Row Gap</Button>
91+
</ToolbarItem>
92+
<ToolbarItem>
93+
<Button variant="secondary">No Row Gap</Button>
94+
</ToolbarItem>
95+
<ToolbarItem>
96+
<Button variant="secondary">No Row Gap</Button>
97+
</ToolbarItem>
98+
<ToolbarItem>
99+
<Button variant="secondary">No Row Gap</Button>
100+
</ToolbarItem>
101+
<ToolbarItem>
102+
<Button variant="secondary">No Row Gap</Button>
103+
</ToolbarItem>
104+
<ToolbarItem variant="separator"></ToolbarItem>
105+
</ToolbarGroup>
106+
<ToolbarGroup className="pf-m-wrap" variant="action-group" rowGap={{ default: 'rowGapSm' }}>
107+
<ToolbarItem>
108+
<Button variant="secondary">Small Row Gap</Button>
109+
</ToolbarItem>
110+
<ToolbarItem>
111+
<Button variant="secondary">Small Row Gap</Button>
112+
</ToolbarItem>
33113
<ToolbarItem>
34-
<Button variant="secondary">Action</Button>
114+
<Button variant="secondary">Small Row Gap</Button>
35115
</ToolbarItem>
36116
<ToolbarItem>
37-
<Button variant="secondary">Action</Button>
117+
<Button variant="secondary">Small Row Gap</Button>
118+
</ToolbarItem>
119+
<ToolbarItem>
120+
<Button variant="secondary">Small Row Gap</Button>
121+
</ToolbarItem>
122+
<ToolbarItem>
123+
<Button variant="secondary">Small Row Gap</Button>
124+
</ToolbarItem>
125+
<ToolbarItem>
126+
<Button variant="secondary">Small Row Gap</Button>
127+
</ToolbarItem>
128+
<ToolbarItem>
129+
<Button variant="secondary">Small Row Gap</Button>
130+
</ToolbarItem>
131+
<ToolbarItem variant="separator"></ToolbarItem>
132+
</ToolbarGroup>
133+
<ToolbarGroup className="pf-m-wrap" variant="action-group" rowGap={{ default: 'rowGapXl' }}>
134+
<ToolbarItem>
135+
<Button variant="secondary">Extra Large Row Gap</Button>
136+
</ToolbarItem>
137+
<ToolbarItem>
138+
<Button variant="secondary">Extra Large Row Gap</Button>
139+
</ToolbarItem>
140+
<ToolbarItem>
141+
<Button variant="secondary">Extra Large Row Gap</Button>
142+
</ToolbarItem>
143+
<ToolbarItem>
144+
<Button variant="secondary">Extra Large Row Gap</Button>
145+
</ToolbarItem>
146+
<ToolbarItem>
147+
<Button variant="secondary">Extra Large Row Gap</Button>
148+
</ToolbarItem>
149+
<ToolbarItem>
150+
<Button variant="secondary">Extra Large Row Gap</Button>
151+
</ToolbarItem>
152+
<ToolbarItem>
153+
<Button variant="secondary">Extra Large Row Gap</Button>
154+
</ToolbarItem>
155+
<ToolbarItem>
156+
<Button variant="secondary">Extra Large Row Gap</Button>
157+
</ToolbarItem>
158+
</ToolbarGroup>
159+
</React.Fragment>
160+
);
161+
162+
const itemGapItems = (
163+
<React.Fragment>
164+
<ToolbarGroup className="pf-m-wrap" variant="action-group">
165+
<ToolbarItem gap={{ default: 'gapNone' }}>
166+
<Button variant="secondary">No Gap</Button>
167+
<Button variant="secondary">No Gap</Button>
168+
</ToolbarItem>
169+
<ToolbarItem variant="separator"></ToolbarItem>
170+
<ToolbarItem gap={{ default: 'gapSm' }}>
171+
<Button variant="secondary">Small Gap</Button>
172+
<Button variant="secondary">Small Gap</Button>
173+
</ToolbarItem>
174+
<ToolbarItem variant="separator"></ToolbarItem>
175+
<ToolbarItem gap={{ default: 'gapXl' }}>
176+
<Button variant="secondary">Extra Large Gap</Button>
177+
<Button variant="secondary">Extra Large Gap</Button>
178+
</ToolbarItem>
179+
</ToolbarGroup>
180+
</React.Fragment>
181+
);
182+
183+
const itemColumnGapItems = (
184+
<React.Fragment>
185+
<ToolbarGroup className="pf-m-wrap" variant="action-group">
186+
<ToolbarItem columnGap={{ default: 'columnGapNone' }}>
187+
<Button variant="secondary">No Column Gap</Button>
188+
<Button variant="secondary">No Column Gap</Button>
189+
</ToolbarItem>
190+
<ToolbarItem variant="separator"></ToolbarItem>
191+
<ToolbarItem columnGap={{ default: 'columnGapSm' }}>
192+
<Button variant="secondary">Small Column Gap</Button>
193+
<Button variant="secondary">Small Column Gap</Button>
194+
</ToolbarItem>
195+
<ToolbarItem variant="separator"></ToolbarItem>
196+
<ToolbarItem columnGap={{ default: 'columnGapXl' }}>
197+
<Button variant="secondary">Extra Large Column Gap</Button>
198+
<Button variant="secondary">Extra Large Column Gap</Button>
199+
</ToolbarItem>
200+
</ToolbarGroup>
201+
</React.Fragment>
202+
);
203+
204+
const itemRowGapItems = (
205+
<React.Fragment>
206+
<ToolbarGroup variant="action-group">
207+
<ToolbarItem className="pf-m-wrap" rowGap={{ default: 'rowGapNone' }}>
208+
<Button variant="secondary">No Row Gap</Button>
209+
<Button variant="secondary">No Row Gap</Button>
210+
</ToolbarItem>
211+
<ToolbarItem variant="separator"></ToolbarItem>
212+
<ToolbarItem className="pf-m-wrap" rowGap={{ default: 'rowGapSm' }}>
213+
<Button variant="secondary">Small Row Gap</Button>
214+
<Button variant="secondary">Small Row Gap</Button>
215+
</ToolbarItem>
216+
<ToolbarItem variant="separator"></ToolbarItem>
217+
<ToolbarItem className="pf-m-wrap" rowGap={{ default: 'rowGapXl' }}>
218+
<Button variant="secondary">Extra Large Row Gap</Button>
219+
<Button variant="secondary">Extra Large Row Gap</Button>
38220
</ToolbarItem>
39221
</ToolbarGroup>
40222
</React.Fragment>
41223
);
42224

43225
return (
44-
<Toolbar id="toolbar-spacers">
45-
<ToolbarContent>{items}</ToolbarContent>
46-
</Toolbar>
226+
<>
227+
<strong>Toolbar Group Spacing:</strong>
228+
<br />
229+
<br />
230+
<Toolbar id="toolbar-spacers">
231+
<ToolbarContent>{groupGapItems}</ToolbarContent>
232+
</Toolbar>
233+
<strong>Using column gap</strong>
234+
<br />
235+
<br />
236+
<Toolbar id="toolbar-spacers">
237+
<ToolbarContent>{groupColumnGapItems}</ToolbarContent>
238+
</Toolbar>
239+
<strong>Using row gap</strong>
240+
<br />
241+
<br />
242+
<Toolbar id="toolbar-spacers">
243+
<ToolbarContent>{groupRowGapItems}</ToolbarContent>
244+
</Toolbar>
245+
<br />
246+
<strong>Toolbar Item Spacing:</strong>
247+
<br />
248+
<br />
249+
<Toolbar id="toolbar-spacers">
250+
<ToolbarContent>{itemGapItems}</ToolbarContent>
251+
</Toolbar>
252+
<strong>Using column gap</strong>
253+
<br />
254+
<br />
255+
<Toolbar id="toolbar-spacers">
256+
<ToolbarContent>{itemColumnGapItems}</ToolbarContent>
257+
</Toolbar>
258+
<strong>Using row gap</strong>
259+
<br />
260+
<br />
261+
<Toolbar id="toolbar-spacers">
262+
<ToolbarContent>{itemRowGapItems}</ToolbarContent>
263+
</Toolbar>
264+
</>
47265
);
48266
};

0 commit comments

Comments
 (0)