fix/add tests for hasAnimations after cli split

Signed-off-by: gitdallas <[email protected]>

Author: gitdallas

packages/eslint-plugin-pf-codemods/src/rules/v6/enableAnimations/enable-animations.test.ts

@@ -18,6 +18,30 @@ const valid = [
 ];
 
 const invalid = [
+  // --- Without includeTable (default) ---
+  {
+    code: "import { Table } from '@patternfly/react-table'; <Table />",
+    output: "import { Table } from '@patternfly/react-table'; <Table />",
+    errors: [
+      { 
+        message: "Consider adding hasAnimations prop to enable component animations.",
+        type: "JSXOpeningElement"
+      }
+    ]
+  },
+  // --- With includeTable: true ---
+  {
+    code: "import { Table } from '@patternfly/react-table'; <Table />",
+    output: "import { Table } from '@patternfly/react-table'; <Table hasAnimations />",
+    errors: [
+      { 
+        message: "Consider adding hasAnimations prop to enable component animations.",
+        type: "JSXOpeningElement"
+      }
+    ],
+    options: [{ includeTable: true }]
+  },
+  // --- Core components (unchanged) ---
   {
     code: "import { AlertGroup } from '@patternfly/react-core'; <AlertGroup />",
     output: "import { AlertGroup } from '@patternfly/react-core'; <AlertGroup hasAnimations />",
@@ -78,27 +102,11 @@ const invalid = [
       }
     ]
   },
-  {
-    code: "import { Table } from '@patternfly/react-table'; <Table />",
-    output: "import { Table } from '@patternfly/react-table'; <Table hasAnimations />",
-    errors: [
-      { 
-        message: "Consider adding hasAnimations prop to enable component animations.",
-        type: "JSXOpeningElement"
-      }
-    ]
-  },
   {
     code: `import { AlertGroup, TreeView } from '@patternfly/react-core'; 
-      <>
-        <AlertGroup />
-        <TreeView />
-      </>`,
+      <><AlertGroup /><TreeView /></>`,
     output: `import { AlertGroup, TreeView } from '@patternfly/react-core'; 
-      <>
-        <AlertGroup hasAnimations />
-        <TreeView hasAnimations />
-      </>`,
+      <><AlertGroup hasAnimations /><TreeView hasAnimations /></>`,
     errors: [
       { 
         message: "Consider adding hasAnimations prop to enable component animations.",

packages/eslint-plugin-pf-codemods/src/rules/v6/enableAnimations/enable-animations.ts

@@ -1,6 +1,6 @@
 import { Rule } from "eslint";
 import { JSXOpeningElement, JSXAttribute } from "estree-jsx";
-import { getFromPackage, checkMatchingJSXOpeningElement } from "../../helpers";
+import { getFromPackage, checkMatchingJSXOpeningElement, getNodeName } from "../../helpers";
 import { getAttribute, getAttributeValue } from "../../helpers/JSXAttributes";
 
 // Rule to add hasAnimations prop to components that support animations
@@ -40,12 +40,10 @@ module.exports = {
       targetComponents.includes(specifier.imported.name)
     );
 
-    // Only include Table if option is set
-    const targetTableImports = includeTable
-      ? tableImports.filter((specifier) =>
-          tableComponents.includes(specifier.imported.name)
-        )
-      : [];
+    // Always include Table imports for detection, but only add hasAnimations if includeTable is true
+    const targetTableImports = tableImports.filter((specifier) =>
+      tableComponents.includes(specifier.imported.name)
+    );
 
     const allTargetImports = [...targetCoreImports, ...targetTableImports];
 
@@ -77,20 +75,14 @@ module.exports = {
       return true;
     }
 
-    // Helper function to get component name from node
-    function getComponentName(node: JSXOpeningElement): string | null {
-      if (node.name.type === "JSXIdentifier") {
-        return node.name.name;
-      }
-      return null;
-    }
+
 
     return allTargetImports.length === 0
       ? {}
       : {
           JSXOpeningElement(node: JSXOpeningElement) {
             if (checkMatchingJSXOpeningElement(node, allTargetImports)) {
-              const componentName = getComponentName(node);
+              const componentName = getNodeName(node);
 
               // Special handling for DualListSelector - only add hasAnimations if isTree is true
               if (componentName === "DualListSelector" && !hasValidIsTreeProp(node)) {
@@ -107,10 +99,13 @@ module.exports = {
 
               // Only add prop if it doesn't already exist
               if (!hasAnimationsAttribute) {
+                // For Table, only apply the fix if includeTable is true
+                const shouldApplyFix = componentName !== "Table" || includeTable;
+                
                 context.report({
                   node,
                   message,
-                  fix(fixer) {
+                  fix: shouldApplyFix ? (fixer) => {
                     // Insert hasAnimations at the end of existing attributes
                     if (node.attributes.length > 0) {
                       const lastAttribute = node.attributes[node.attributes.length - 1];
@@ -119,7 +114,7 @@ module.exports = {
                       // No existing attributes, insert after component name
                       return fixer.insertTextAfter(node.name, " hasAnimations");
                     }
-                  },
+                  } : undefined,
                 });
               }
             }