fix(BulkSelect): expose correct additional props

Replace dropdownListProps with menuToggleProps in the component's API.
This is necessary for the Content Services use case, as we need to
programmatically disable the split button toggle. Previously, we were
mistakenly exposing dropdownListProps, which are not needed for this.

Author: katarinazaprazna

packages/module/src/BulkSelect/BulkSelect.test.tsx

@@ -1,5 +1,4 @@
 import { render, screen } from '@testing-library/react';
-import userEvent from '@testing-library/user-event';
 import BulkSelect from './BulkSelect';
 
 describe('BulkSelect component', () => {
@@ -16,8 +15,7 @@ describe('BulkSelect component', () => {
       />)).toMatchSnapshot();
   });
 
-  test('should render with dropdownListProps', async () => {
-    const user = userEvent.setup();
+  test('should render with menuToggleProps', () => {
     render(
       <BulkSelect
         canSelectAll
@@ -27,17 +25,14 @@ describe('BulkSelect component', () => {
         pageSelected={false}
         pagePartiallySelected={true}
         onSelect={() => null}
-        dropdownListProps={{ className: 'custom-dropdown-list' }}
+        menuToggleProps={{ isDisabled: true, className: 'custom-menu-toggle' }}
       />
     );
 
-    // Open the dropdown by clicking the toggle button
+    // Confirm the split button toggle receives the custom props
     const toggleButton = screen.getByLabelText('Bulk select toggle');
-    await user.click(toggleButton);
-
-    // Now the dropdown list should be visible with the custom class
-    const dropdownList = document.querySelector('.custom-dropdown-list');
-    expect(dropdownList).toBeInTheDocument();
-    expect(dropdownList).toHaveClass('pf-v6-c-menu__list');
+    expect(toggleButton).toBeInTheDocument();
+    expect(toggleButton).toBeDisabled();
+    expect(toggleButton).toHaveClass('custom-menu-toggle');
   });
 });

packages/module/src/BulkSelect/BulkSelect.tsx

@@ -4,12 +4,12 @@ import {
   Dropdown,
   DropdownItem,
   DropdownList,
-  DropdownListProps,
   DropdownProps,
   MenuToggle,
   MenuToggleCheckbox,
   MenuToggleCheckboxProps,
-  MenuToggleElement
+  MenuToggleElement,
+  MenuToggleProps
 } from '@patternfly/react-core';
 
 export const BulkSelectValue = {
@@ -45,8 +45,8 @@ export interface BulkSelectProps extends Omit<DropdownProps, 'toggle' | 'onSelec
   ouiaId?: string;
   /** Additional props for MenuToggleCheckbox */
   menuToggleCheckboxProps?: Omit<MenuToggleCheckboxProps, 'onChange' | 'isChecked' | 'instance' | 'ref'>;
-  /** Additional props for DropdownList */
-  dropdownListProps?: Omit<DropdownListProps, 'children'>;
+  /** Additional props for MenuToggleProps */
+  menuToggleProps?: Omit<MenuToggleProps, 'children' | 'splitButtonItems' | 'ref' | 'isExpanded' | 'onClick'>;
 }
 
 export const BulkSelect: FC<BulkSelectProps> = ({
@@ -60,7 +60,7 @@ export const BulkSelect: FC<BulkSelectProps> = ({
   ouiaId = 'BulkSelect',
   onSelect,
   menuToggleCheckboxProps,
-  dropdownListProps,
+  menuToggleProps,
   ...props
 }: BulkSelectProps) => {
   const [ isOpen, setOpen ] = useState(false);
@@ -116,7 +116,7 @@ export const BulkSelect: FC<BulkSelectProps> = ({
               aria-label={`Select ${allOption}`}
               isChecked={
                 (isDataPaginated && pagePartiallySelected) ||
-                  (!isDataPaginated && selectedCount > 0 && selectedCount < totalCount)
+                (!isDataPaginated && selectedCount > 0 && selectedCount < totalCount)
                   ? null
                   : pageSelected || (selectedCount === totalCount && totalCount > 0)
               }
@@ -129,11 +129,12 @@ export const BulkSelect: FC<BulkSelectProps> = ({
               </span>
             ) : null
           ]}
+          {...menuToggleProps}
         />
       )}
       {...props}
     >
-      <DropdownList {...dropdownListProps}>{splitButtonDropdownItems}</DropdownList>
+      <DropdownList>{splitButtonDropdownItems}</DropdownList>
     </Dropdown>)
   );
 };