Skip to content

Commit 08accd6

Browse files
committed
fix(BulkSelect): Fix BulkSelect being checked when there are no rows (#355)
1 parent a441bae commit 08accd6

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/module/src/BulkSelect/BulkSelect.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ export const BulkSelect: React.FC<BulkSelectProps> = ({
101101
isExpanded={isOpen}
102102
onClick={onToggleClick}
103103
aria-label="Bulk select toggle"
104-
ouiaId={`${ouiaId}-toggle`}
104+
data-ouia-component-id={`${ouiaId}-toggle`}
105105
splitButtonItems={[
106106
<MenuToggleCheckbox
107107
ouiaId={`${ouiaId}-checkbox`}
@@ -110,9 +110,9 @@ export const BulkSelect: React.FC<BulkSelectProps> = ({
110110
aria-label={`Select ${allOption}`}
111111
isChecked={
112112
(isDataPaginated && pagePartiallySelected) ||
113-
(!isDataPaginated && selectedCount > 0 && selectedCount < totalCount)
113+
(!isDataPaginated && selectedCount > 0 && selectedCount < totalCount)
114114
? null
115-
: pageSelected || selectedCount === totalCount
115+
: pageSelected || (selectedCount === totalCount && totalCount > 0)
116116
}
117117
onChange={(checked) => onSelect?.(!checked || checked === null ? noneOption : allOption)}
118118
{...menuToggleCheckboxProps}

0 commit comments

Comments
 (0)