Skip to content

Commit 15a0f55

Browse files
committed
fix: address column accessibility issues
1 parent ab3fc5a commit 15a0f55

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

packages/module/src/ColumnManagement/ColumnManagement.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import {
1515
Checkbox,
1616
Dropdown,
1717
DropdownItem,
18+
DropdownList,
1819
MenuToggle
1920
} from '@patternfly/react-core';
2021
import {
@@ -131,16 +132,19 @@ const ColumnManagement: FunctionComponent<ColumnProps> = (
131132
onClick={() => setIsDropdownOpen(!isDropdownOpen)}
132133
isExpanded={isDropdownOpen}
133134
>
134-
<Checkbox
135-
aria-label="Select all"
136-
isChecked={isAllSelected() ? true : isSomeSelected() ? null : false}
137-
id={`${ouiaId}-select-all-checkbox`}
138-
/>
135+
<div>
136+
<Checkbox
137+
aria-label="Select all"
138+
tabIndex={-1}
139+
isChecked={isAllSelected() ? true : isSomeSelected() ? null : false}
140+
id={`${ouiaId}-select-all-checkbox`}
141+
/>
142+
</div>
139143
</MenuToggle>
140144
)}
141145
isOpen={isDropdownOpen}
142146
>
143-
{dropdownItems}
147+
<DropdownList>{dropdownItems}</DropdownList>
144148
</Dropdown>
145149
</div>
146150
<DragDrop onDrop={onDrag}>

0 commit comments

Comments
 (0)