fix(BulkSelect): Fix BulkSelect being checked when there are no rows (#355)

fhlavac · web-flow · commit 88a929bf16d1 · 2024-09-26T10:58:05.000-04:00
diff --git a/packages/module/src/BulkSelect/BulkSelect.tsx b/packages/module/src/BulkSelect/BulkSelect.tsx
@@ -113,7 +113,7 @@ export const BulkSelect: React.FC<BulkSelectProps> = ({
                   (isDataPaginated && pagePartiallySelected) ||
                   (!isDataPaginated && selectedCount > 0 && selectedCount < totalCount)
                     ? null
-                    : pageSelected || selectedCount === totalCount
+                    : pageSelected || (selectedCount === totalCount && totalCount > 0)
                 }
                 onChange={(checked) => onSelect?.(!checked || checked === null ? noneOption : allOption)}
                 {...menuToggleCheckboxProps}

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ export const BulkSelect: React.FC<BulkSelectProps> = ({`
`113`	`113`	`(isDataPaginated && pagePartiallySelected) \|\|`
`114`	`114`	`(!isDataPaginated && selectedCount > 0 && selectedCount < totalCount)`
`115`	`115`	`? null`
`116`		`- : pageSelected \|\| selectedCount === totalCount`
	`116`	`+ : pageSelected \|\| (selectedCount === totalCount && totalCount > 0)`
`117`	`117`	`}`
`118`	`118`	`onChange={(checked) => onSelect?.(!checked \|\| checked === null ? noneOption : allOption)}`
`119`	`119`	`{...menuToggleCheckboxProps}`