Skip to content

Commit 0c80f77

Browse files
committed
fix(events): Fix the events example
1 parent 0ae4fc8 commit 0c80f77

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

packages/module/patternfly-docs/content/extensions/data-view/examples/EventsContext/EventsExample.tsx

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,20 @@ interface RepositoriesTableProps {
6666

6767
const RepositoriesTable: React.FunctionComponent<RepositoriesTableProps> = ({ selectedRepo = undefined }) => {
6868
const { trigger } = useDataViewEventsContext();
69-
70-
// eslint-disable-next-line react-hooks/exhaustive-deps
71-
const rows = useMemo(() => repositories.map(repo => ({ row: Object.values(repo), props: { isClickable: true, onRowClick: () => handleRowClick(selectedRepo?.name === repo.name ? undefined : repo), isRowSelected: selectedRepo?.name === repo.name } } )), [ selectedRepo?.name ]);
72-
73-
const handleRowClick = (repo: Repository | undefined) => {
74-
trigger(EventTypes.rowClick, repo);
75-
};
69+
const rows = useMemo(() => {
70+
const handleRowClick = (repo: Repository | undefined) => {
71+
trigger(EventTypes.rowClick, repo);
72+
};
73+
74+
return repositories.map(repo => ({
75+
row: Object.values(repo),
76+
props: {
77+
isClickable: true,
78+
onRowClick: () => handleRowClick(selectedRepo?.name === repo.name ? undefined : repo),
79+
isRowSelected: selectedRepo?.name === repo.name
80+
}
81+
}));
82+
}, [ selectedRepo?.name, trigger ]);
7683

7784
return (
7885
<DataView>

packages/module/src/DataViewTable/DataViewTable.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22
import { render } from '@testing-library/react';
3-
import { DataViewTable } from '@patternfly/react-data-view/dist/dynamic/DataViewTable';
3+
import { DataViewTable } from './DataViewTable';
44

55
interface Repository {
66
name: string;

0 commit comments

Comments
 (0)