update typescript version

Author: nicolethoen

package-lock.json

@@ -55,6 +55,6 @@
     "react-router": "^6.30.1",
     "react-router-dom": "^6.30.1",
     "rimraf": "^6.0.1",
-    "typescript": "^5.4.5"
+    "typescript": "^5.8.3"
   }
 }

packages/module/package.json

@@ -1,5 +1,5 @@
 import React from 'react';
-import { render } from '@testing-library/react';
+import { render, fireEvent } from '@testing-library/react';
 import DataViewFilters from './DataViewFilters';
 import DataViewToolbar from '../DataViewToolbar';
 import DataViewTextFilter from '../DataViewTextFilter';
@@ -18,4 +18,28 @@ describe('DataViewFilters component', () => {
     />);
     expect(container).toMatchSnapshot();
   });
+
+  it('should call onChange with correct key and value when filter changes', () => {
+    const mockOnChange = jest.fn();
+    const { getByLabelText } = render(
+      <DataViewToolbar
+        filters={
+          <DataViewFilters onChange={mockOnChange} values={{}}>
+            <DataViewTextFilter filterId="one" title="One" />
+            <DataViewTextFilter filterId="two" title="Two" />
+          </DataViewFilters>
+        }
+      />
+    );
+    const input = getByLabelText('One filter');
+    // Simulate user typing 'abc' in the input
+    input.focus();
+    // fireEvent.change triggers the onChange handler of the input
+    // The SearchInput component expects the value as the second argument
+    // so we use fireEvent.change with { target: { value: 'abc' } }
+    // but since SearchInput is a custom component, we use fireEvent.input
+    // to trigger the native input event
+    fireEvent.input(input, { target: { value: 'abc' } });
+    expect(mockOnChange).toHaveBeenCalledWith('one', { one: 'abc' });
+  });
 });

packages/module/src/DataViewFilters/DataViewFilters.test.tsx

@@ -130,7 +130,7 @@ export const DataViewFilters = <T extends object>({
               value: unknown;
             }>, {
               showToolbarItem: activeAttributeMenu === child.props.title,
-              onChange: (event, value) => onChange?.(event, { [child.props.filterId]: value } as Partial<T>),
+              onChange: (event, value) => onChange?.(child.props.filterId, { [child.props.filterId]: value } as Partial<T>),
               value: values?.[child.props.filterId],
               ...child.props
             })