Skip to content

Commit afaa64f

Browse files
committed
feat(loading): Rename DataViewTableHead
1 parent ddc98cf commit afaa64f

File tree

6 files changed

+21
-23
lines changed

6 files changed

+21
-23
lines changed

cypress/component/DataViewTableHeader.cy.tsx renamed to cypress/component/DataViewTableHead.cy.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import React from 'react';
2-
import { DataViewTableHeader } from '@patternfly/react-data-view/dist/dynamic/DataViewTableHeader';
2+
import { DataViewTableHead } from '@patternfly/react-data-view/dist/dynamic/DataViewTableHead';
33

44
const columns = [ 'Repositories', 'Branches', 'Pull requests', 'Workspaces', 'Last commit' ];
55

6-
describe('DataViewTableHeader', () => {
6+
describe('DataViewTableHead', () => {
77

8-
it('renders a data view table header', () => {
8+
it('renders a data view table head', () => {
99
const ouiaId = 'data';
1010

1111
cy.mount(
12-
<DataViewTableHeader ouiaId={ouiaId} columns={columns} />
12+
<DataViewTableHead ouiaId={ouiaId} columns={columns} />
1313
);
1414

1515
cy.get('[data-ouia-component-id="data-th-0"]').contains('Repositories');

packages/module/src/DataViewTableHeader/DataViewTableHeader.test.tsx renamed to packages/module/src/DataViewTableHead/DataViewTableHead.test.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import React from 'react';
22
import { render } from '@testing-library/react';
33
import { Table } from '@patternfly/react-table';
4-
import { DataViewTableHeader } from './DataViewTableHeader';
4+
import { DataViewTableHead } from './DataViewTableHead';
55
import { DataViewSelection } from '../InternalContext';
66
import { DataView } from '../DataView';
77

88
const columns = [ 'Repositories', 'Branches', 'Pull requests', 'Workspaces', 'Last commit' ];
99

1010
const ouiaId = 'HeaderExample';
1111

12-
describe('DataViewTableHeader component', () => {
12+
describe('DataViewTableHead component', () => {
1313
const mockSelection: DataViewSelection = {
1414
onSelect: jest.fn(),
1515
isSelected: jest.fn(),
@@ -19,7 +19,7 @@ describe('DataViewTableHeader component', () => {
1919
test('should render correctly', () => {
2020
const { container } = render(
2121
<Table>
22-
<DataViewTableHeader columns={columns} ouiaId={ouiaId} />
22+
<DataViewTableHead columns={columns} ouiaId={ouiaId} />
2323
</Table>
2424
);
2525
expect(container).toMatchSnapshot();
@@ -29,7 +29,7 @@ describe('DataViewTableHeader component', () => {
2929
const { container } = render(
3030
<DataView selection={mockSelection}>
3131
<Table>
32-
<DataViewTableHeader isTreeTable columns={columns} ouiaId={ouiaId} />
32+
<DataViewTableHead isTreeTable columns={columns} ouiaId={ouiaId} />
3333
</Table>
3434
</DataView>
3535
);
@@ -40,13 +40,11 @@ describe('DataViewTableHeader component', () => {
4040
const { container } = render(
4141
<DataView selection={mockSelection}>
4242
<Table>
43-
<DataViewTableHeader columns={columns} ouiaId={ouiaId} />
43+
<DataViewTableHead columns={columns} ouiaId={ouiaId} />
4444
</Table>
4545
</DataView>
4646
);
4747
expect(container).toMatchSnapshot();
4848
});
4949
});
5050

51-
52-

packages/module/src/DataViewTableHeader/DataViewTableHeader.tsx renamed to packages/module/src/DataViewTableHead/DataViewTableHead.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
import { useInternalContext } from '../InternalContext';
99
import { DataViewTh, isDataViewThObject } from '../DataViewTable';
1010

11-
export interface DataViewTableHeaderProps extends TheadProps {
11+
export interface DataViewTableHeadProps extends TheadProps {
1212
/** Indicates whether table is a tree */
1313
isTreeTable?: boolean;
1414
/** Columns definition */
@@ -17,18 +17,18 @@ export interface DataViewTableHeaderProps extends TheadProps {
1717
ouiaId?: string;
1818
}
1919

20-
export const DataViewTableHeader: React.FC<DataViewTableHeaderProps> = ({
20+
export const DataViewTableHead: React.FC<DataViewTableHeadProps> = ({
2121
isTreeTable = false,
2222
columns,
23-
ouiaId = 'DataViewTableHeader',
23+
ouiaId = 'DataViewTableHead',
2424
...props
25-
}: DataViewTableHeaderProps) => {
25+
}: DataViewTableHeadProps) => {
2626
const { selection } = useInternalContext();
2727
const { onSelect, isSelected } = selection ?? {};
2828

2929
const cells = useMemo(() => [
3030
onSelect && isSelected && !isTreeTable ? (
31-
<Th key="row-select" screenReaderText='Data selection table header cell' />
31+
<Th key="row-select" screenReaderText='Data selection table head cell' />
3232
) : null,
3333
...columns.map((column, index) => (
3434
<Th
@@ -50,4 +50,4 @@ export const DataViewTableHeader: React.FC<DataViewTableHeaderProps> = ({
5050
);
5151
};
5252

53-
export default DataViewTableHeader;
53+
export default DataViewTableHead;

packages/module/src/DataViewTableHeader/__snapshots__/DataViewTableHeader.test.tsx.snap renamed to packages/module/src/DataViewTableHead/__snapshots__/DataViewTableHead.test.tsx.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

3-
exports[`DataViewTableHeader component should render correctly 1`] = `
3+
exports[`DataViewTableHead component should render correctly 1`] = `
44
<div>
55
<table
66
class="pf-v5-c-table pf-m-grid-md"
@@ -65,7 +65,7 @@ exports[`DataViewTableHeader component should render correctly 1`] = `
6565
</div>
6666
`;
6767

68-
exports[`DataViewTableHeader component should render selection column when selection is provided 1`] = `
68+
exports[`DataViewTableHead component should render selection column when selection is provided 1`] = `
6969
<div>
7070
<div
7171
class="pf-v5-l-stack"
@@ -100,7 +100,7 @@ exports[`DataViewTableHeader component should render selection column when selec
100100
<span
101101
class="pf-v5-screen-reader"
102102
>
103-
Data selection table header cell
103+
Data selection table head cell
104104
</span>
105105
</th>
106106
<th
@@ -151,7 +151,7 @@ exports[`DataViewTableHeader component should render selection column when selec
151151
</div>
152152
`;
153153

154-
exports[`DataViewTableHeader component should render the tree table correctly when isTreeTable is true 1`] = `
154+
exports[`DataViewTableHead component should render the tree table correctly when isTreeTable is true 1`] = `
155155
<div>
156156
<div
157157
class="pf-v5-l-stack"
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
export { default } from './DataViewTableHead';
2+
export * from './DataViewTableHead';

packages/module/src/DataViewTableHeader/index.ts

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)