Skip to content

Commit bebc9b5

Browse files
fhlavacfhlavac
committed
feat(states): Update tests
1 parent 5655881 commit bebc9b5

File tree

4 files changed

+73
-5
lines changed

4 files changed

+73
-5
lines changed

‎cypress/component/DataViewTableBasic.cy.tsx‎

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React from 'react';
2-
import DataViewTableBasic from '@patternfly/react-data-view/dist/esm/DataViewTableBasic';
2+
import DataViewTableBasic from '@patternfly/react-data-view/dist/dynamic/DataViewTableBasic';
3+
import DataView from '@patternfly/react-data-view/dist/dynamic/DataView';
34

45
interface Repository {
56
name: string;
@@ -48,7 +49,9 @@ describe('DataViewTableBasic', () => {
4849
const ouiaId = 'data';
4950

5051
cy.mount(
51-
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} emptyState="No data found" />
52+
<DataView activeState="empty">
53+
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} states={{ empty: "No data found" }} />
54+
</DataView>
5255
);
5356

5457
cy.get('[data-ouia-component-id="data-th-0"]').contains('Repositories');
@@ -60,4 +63,23 @@ describe('DataViewTableBasic', () => {
6063
cy.get('[data-ouia-component-id="data-tr-empty"]').should('be.visible');
6164
cy.get('[data-ouia-component-id="data-tr-empty"]').contains('No data found');
6265
});
66+
67+
it('renders a basic data view table with an error state', () => {
68+
const ouiaId = 'data';
69+
70+
cy.mount(
71+
<DataView activeState="error">
72+
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} states={{ error: "Some error" }} />
73+
</DataView>
74+
);
75+
76+
cy.get('[data-ouia-component-id="data-th-0"]').contains('Repositories');
77+
cy.get('[data-ouia-component-id="data-th-1"]').contains('Branches');
78+
cy.get('[data-ouia-component-id="data-th-2"]').contains('Pull requests');
79+
cy.get('[data-ouia-component-id="data-th-3"]').contains('Workspaces');
80+
cy.get('[data-ouia-component-id="data-th-4"]').contains('Last commit');
81+
82+
cy.get('[data-ouia-component-id="data-tr-error"]').should('be.visible');
83+
cy.get('[data-ouia-component-id="data-tr-error"]').contains('Some error');
84+
});
6385
});

‎cypress/component/DataViewTableTree.cy.tsx‎

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React from 'react';
22
import { DataViewTable, DataViewTrTree } from '@patternfly/react-data-view/dist/dynamic/DataViewTable';
3+
import DataView from '@patternfly/react-data-view/dist/dynamic/DataView';
34

45
interface Repository {
56
name: string;
@@ -130,7 +131,9 @@ describe('DataViewTableTree', () => {
130131
const ouiaId = 'tree';
131132

132133
cy.mount(
133-
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} emptyState="No data found" />
134+
<DataView activeState="empty">
135+
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} states={{ empty: "No data found" }} />
136+
</DataView>
134137
);
135138

136139
cy.get('[data-ouia-component-id="tree-th-0"]').contains('Repositories');
@@ -142,4 +145,23 @@ describe('DataViewTableTree', () => {
142145
cy.get('[data-ouia-component-id="tree-tr-empty"]').should('be.visible');
143146
cy.get('[data-ouia-component-id="tree-tr-empty"]').contains('No data found');
144147
});
148+
149+
it('renders a tree data view table with an error state', () => {
150+
const ouiaId = 'data';
151+
152+
cy.mount(
153+
<DataView activeState="error">
154+
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} rows={[]} states={{ error:"Some error" }} />
155+
</DataView>
156+
);
157+
158+
cy.get('[data-ouia-component-id="data-th-0"]').contains('Repositories');
159+
cy.get('[data-ouia-component-id="data-th-1"]').contains('Branches');
160+
cy.get('[data-ouia-component-id="data-th-2"]').contains('Pull requests');
161+
cy.get('[data-ouia-component-id="data-th-3"]').contains('Workspaces');
162+
cy.get('[data-ouia-component-id="data-th-4"]').contains('Last commit');
163+
164+
cy.get('[data-ouia-component-id="data-tr-error"]').should('be.visible');
165+
cy.get('[data-ouia-component-id="data-tr-error"]').contains('Some error');
166+
});
145167
});

‎packages/module/src/DataViewTableBasic/DataViewTableBasic.test.tsx‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import React from 'react';
22
import { render } from '@testing-library/react';
33
import { DataViewTableBasic } from './DataViewTableBasic';
4+
import DataView from '../DataView/DataView';
45

56
interface Repository {
67
name: string;
@@ -37,7 +38,18 @@ describe('DataViewTable component', () => {
3738

3839
test('should render with an empty state', () => {
3940
const { container } = render(
40-
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} emptyState="No data found" rows={[]} />
41+
<DataView activeState="empty">
42+
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} states={{ empty:"No data found" }} rows={[]} />
43+
</DataView>
44+
);
45+
expect(container).toMatchSnapshot();
46+
});
47+
48+
test('should render with an error state', () => {
49+
const { container } = render(
50+
<DataView activeState="error">
51+
<DataViewTableBasic aria-label='Repositories table' ouiaId={ouiaId} columns={columns} states={{ error:"Some error" }} rows={[]} />
52+
</DataView>
4153
);
4254
expect(container).toMatchSnapshot();
4355
});

‎packages/module/src/DataViewTableTree/DataViewTableTree.test.tsx‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,19 @@ describe('DataViewTableTree component', () => {
8585

8686
test('should render tree table with an empty state', () => {
8787
const { container } = render(
88-
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} emptyState="No data found" rows={[]} />
88+
<DataView activeState="empty">
89+
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} states={{ empty: "No data found" }} rows={[]} />
90+
91+
</DataView>
92+
);
93+
expect(container).toMatchSnapshot();
94+
});
95+
96+
test('should render tree table with an error state', () => {
97+
const { container } = render(
98+
<DataView activeState="error">
99+
<DataViewTable isTreeTable aria-label='Repositories table' ouiaId={ouiaId} columns={columns} states={{ error: "Some error" }} rows={[]} />
100+
</DataView>
89101
);
90102
expect(container).toMatchSnapshot();
91103
});

0 commit comments

Comments
 (0)