Exclude temperature from being automatically added to OpenAI LLM parameters (#971)

* Exclude `temperature` from being automatically added to OpenAI LLM parameters

* fix linter

Author: andreibondarev

CHANGELOG.md

@@ -16,6 +16,7 @@
 - [BREAKING] [https://github.com/patterns-ai-core/langchainrb/pull/956] Deprecate `Langchain::Vectorsearch::Epsilla` class
 - [BREAKING] [https://github.com/patterns-ai-core/langchainrb/pull/961] Deprecate `Langchain::LLM::LlamaCpp` class
 - [BREAKING] [https://github.com/patterns-ai-core/langchainrb/pull/962] Deprecate `Langchain::LLM::AI21` class
+- [BREAKING] [https://github.com/patterns-ai-core/langchainrb/pull/971] Exclude `temperature` from being automatically added to OpenAI LLM parameters
 
 ## [0.19.4] - 2025-02-17
 - [BREAKING] [https://github.com/patterns-ai-core/langchainrb/pull/894] Tools can now output image_urls, and all tool output must be wrapped by a tool_response() method

lib/langchain/llm/openai.rb

@@ -15,7 +15,6 @@ module Langchain::LLM
   class OpenAI < Base
     DEFAULTS = {
       n: 1,
-      temperature: 0.0,
       chat_model: "gpt-4o-mini",
       embedding_model: "text-embedding-3-small"
     }.freeze

spec/langchain/llm/openai_spec.rb

@@ -316,9 +316,7 @@
           parameters: {
             n: 1,
             model: "gpt-4o-mini",
-            messages: [{content: "Hello World", role: "user"}],
-            temperature: 0.0
-            # max_tokens: 4087
+            messages: [{content: "Hello World", role: "user"}]
           }
         }
       end
@@ -359,9 +357,7 @@
             {
               n: 1,
               model: "text-davinci-003",
-              prompt: "Hello World",
-              temperature: 0.0
-              # max_tokens: 4095
+              prompt: "Hello World"
             }
           }
         end
@@ -375,10 +371,8 @@
           expect(subject.client).to receive(:chat).with({
             parameters: {
               n: 1,
-              # max_tokens: 4087,
               model: "gpt-4o-mini",
-              messages: [{content: "Hello World", role: "user"}],
-              temperature: 0.0
+              messages: [{content: "Hello World", role: "user"}]
             }
           }).and_return(response)
           subject.complete(prompt: "Hello World")
@@ -398,9 +392,7 @@
             parameters: {
               n: 1,
               model: "gpt-3.5-turbo",
-              messages: [{content: "Hello World", role: "user"}],
-              temperature: 0.0 # ,
-              # max_tokens: 4086
+              messages: [{content: "Hello World", role: "user"}]
             }
           }
         end
@@ -409,10 +401,8 @@
           expect(subject.client).to receive(:chat).with({
             parameters: {
               n: 1,
-              # max_tokens: 4087 ,
               model: "gpt-4o-mini",
-              messages: [{content: "Hello World", role: "user"}],
-              temperature: 0.0
+              messages: [{content: "Hello World", role: "user"}]
             }
           }).and_return(response)
           subject.complete(prompt: "Hello World")
@@ -422,19 +412,19 @@
 
     context "with prompt and parameters" do
       let(:parameters) do
-        {parameters: {n: 1, model: "gpt-3.5-turbo", messages: [{content: "Hello World", role: "user"}], temperature: 1.0}} # , max_tokens: 4087}}
+        {parameters: {n: 1, model: "gpt-3.5-turbo", messages: [{content: "Hello World", role: "user"}]}}
       end
 
       it "returns a completion" do
-        response = subject.complete(prompt: "Hello World", model: "gpt-3.5-turbo", temperature: 1.0)
+        response = subject.complete(prompt: "Hello World", model: "gpt-3.5-turbo")
 
         expect(response.completion).to eq("The meaning of life is subjective and can vary from person to person.")
       end
     end
 
     context "with failed API call" do
       let(:parameters) do
-        {parameters: {n: 1, model: "gpt-4o-mini", messages: [{content: "Hello World", role: "user"}], temperature: 0.0}} # , max_tokens: 4087}}
+        {parameters: {n: 1, model: "gpt-4o-mini", messages: [{content: "Hello World", role: "user"}]}}
       end
       let(:response) do
         {"error" => {"code" => 400, "message" => "User location is not supported for the API use.", "type" => "invalid_request_error"}}
@@ -470,10 +460,9 @@
   describe "#chat" do
     let(:prompt) { "What is the meaning of life?" }
     let(:model) { "gpt-4o-mini" }
-    let(:temperature) { 0.0 }
     let(:n) { 1 }
     let(:history) { [content: prompt, role: "user"] }
-    let(:parameters) { {parameters: {n: n, messages: history, model: model, temperature: temperature}} }  # max_tokens: be_between(4014, 4096)}} }
+    let(:parameters) { {parameters: {n: n, messages: history, model: model}} }
     let(:answer) { "As an AI language model, I don't have feelings, but I'm functioning well. How can I assist you today?" }
     let(:answer_2) { "Alternative answer" }
     let(:choices) do
@@ -585,11 +574,10 @@
     end
 
     context "with options" do
-      let(:temperature) { 0.75 }
       let(:model) { "gpt-3.5-turbo-0301" }
 
       it "sends prompt as message and additional params and returns a response message" do
-        response = subject.complete(prompt: prompt, model: model, temperature: temperature)
+        response = subject.complete(prompt: prompt, model: model)
 
         expect(response.chat_completion).to eq(answer)
       end
@@ -612,7 +600,7 @@
         end
 
         it "returns multiple response messages" do
-          response = subject.chat(messages: [content: prompt, role: "user"], model: model, temperature: temperature, n: 2)
+          response = subject.chat(messages: [content: prompt, role: "user"], model: model, n: 2)
 
           expect(response.completions).to eq(choices)
         end