Suppress a Ruby 3.4 warning for URI parser #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR suppresses the following Ruby 3.4's warning. e.g.; ```console $ ruby -v ruby 3.4.3 (2025-04-14 revision d0b7e5b6a0) +PRISM [x86_64-darwin24] $ RUBYOPT=-w bundle exec rspec spec/langchain/loader_spec.rb /Users/koic/src/github.com/patterns-ai-core/langchainrb/lib/langchain/loader.rb:94: warning: URI::RFC3986_PARSER.escape is obsolete. Use URI::RFC2396_PARSER.escape explicitly. ``` Compatibility with Ruby 3.1 supported by Langchain.rb is preserved.
koic
force-pushed
the
suppress_ruby34_url_parser_warning
branch
from
0381dcb to
f7a1241
Compare
| escaped_url = URI::DEFAULT_PARSER.escape(unescaped_url) | ||
|
|
||
| # Ensure compatibility with `URI::RFC2396_PARSER` (Ruby 3.4+) and `URI::DEFAULT_PARSER` (<= 3.3). | ||
| uri_parser = defined?(URI::RFC2396_PARSER) ? URI::RFC2396_PARSER : URI::DEFAULT_PARSER |
There was a problem hiding this comment.
Instead of doing this in a few different places -- it would probably make sense to define it as a Util and obfuscate the actual class used: URI::RFC2396_PARSER or URI::DEFAULT_PARSER?
There was a problem hiding this comment.
That makes sense! I opened PR #994.
koic
added a commit
to koic/langchainrb
that referenced
this pull request
May 17, 2025
This refactoring moves compatibility handling for `URI::RFC2396_PARSER` (Ruby 3.4+) and `URI::DEFAULT_PARSER` (<= 3.3) into `Langchain::Utils::UriParser`. Follow-up to patterns-ai-core#980 (comment).
koic
added a commit
to koic/langchainrb
that referenced
this pull request
May 17, 2025
This refactoring moves compatibility handling for `URI::RFC2396_PARSER` (Ruby 3.4+) and `URI::DEFAULT_PARSER` (<= 3.3) into `Langchain::Utils::UriParser`. Follow-up to patterns-ai-core#980 (comment).
koic
added a commit
to koic/langchainrb
that referenced
this pull request
May 17, 2025
This refactoring moves compatibility handling for `URI::RFC2396_PARSER` (Ruby 3.4+) and `URI::DEFAULT_PARSER` (<= 3.3) into `Langchain::Utils::UriParser`. Follow-up to patterns-ai-core#980 (comment).
koic
added a commit
to koic/langchainrb
that referenced
this pull request
Jun 12, 2025
This refactoring moves compatibility handling for `URI::RFC2396_PARSER` (Ruby 3.4+) and `URI::DEFAULT_PARSER` (<= 3.3) into `Langchain::Utils::UriParser`. Follow-up to patterns-ai-core#980 (comment).
littlechu
pushed a commit
to littlechu/openai_assistant_fix
that referenced
this pull request
Jul 8, 2025
This PR suppresses the following Ruby 3.4's warning. e.g.; ```console $ ruby -v ruby 3.4.3 (2025-04-14 revision d0b7e5b6a0) +PRISM [x86_64-darwin24] $ RUBYOPT=-w bundle exec rspec spec/langchain/loader_spec.rb /Users/koic/src/github.com/patterns-ai-core/langchainrb/lib/langchain/loader.rb:94: warning: URI::RFC3986_PARSER.escape is obsolete. Use URI::RFC2396_PARSER.escape explicitly. ``` Compatibility with Ruby 3.1 supported by Langchain.rb is preserved. Co-authored-by: Andrei Bondarev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses the following Ruby 3.4's warning. e.g.;
Compatibility with Ruby 3.1 supported by Langchain.rb is preserved.