Fixes

Author: andreibondarev

lib/weaviate/objects.rb

@@ -23,12 +23,8 @@ def list(
         req.params["sort"] = sort unless sort.nil?
         req.params["order"] = order unless order.nil?
       end
-      
-      if response.success?
-        response.body
-      else
-        response.body
-      end
+
+      response.body
     end
 
     # Create a new data object. The provided meta-data and schema values are validated.
@@ -42,9 +38,11 @@ def create(
       validate_consistency_level!(consistency_level) unless consistency_level.nil?
 
       response = client.connection.post(PATH) do |req|
-        req.params = {
-          consistency_level: consistency_level.to_s.upcase
-        } unless consistency_level.nil?
+        unless consistency_level.nil?
+          req.params = {
+            consistency_level: consistency_level.to_s.upcase
+          }
+        end
 
         req.body = {}
         req.body["class"] = class_name
@@ -53,11 +51,7 @@ def create(
         req.body["vector"] = vector unless vector.nil?
       end
 
-      if response.success?
-        response.body
-      else
-        response.body
-      end
+      response.body
     end
 
     # Batch create objects
@@ -72,11 +66,7 @@ def batch_create(
         req.body = {objects: objects}
       end
 
-      if response.success?
-        response.body
-      else
-        response.body
-      end
+      response.body
     end
 
     # Get a single data object.
@@ -93,11 +83,7 @@ def get(
         req.params["include"] = include unless include.nil?
       end
 
-      if response.success?
-        response.body
-      else
-        response.body
-      end
+      response.body
     end
 
     # Check if a data object exists
@@ -134,12 +120,8 @@ def update(
         req.body["properties"] = properties
         req.body["vector"] = vector unless vector.nil?
       end
-      
-      if response.success?
-        response.body
-      else
-        response.body
-      end
+
+      response.body
     end
 
     # Delete an individual data object from Weaviate.
@@ -169,7 +151,7 @@ def batch_delete(
       dry_run: nil
     )
       path = "batch/#{PATH}"
-      
+
       unless consistency_level.nil?
         validate_consistency_level!(consistency_level)
 

lib/weaviate/query.rb

@@ -28,7 +28,7 @@ def get(
         limit: limit,
         offset: offset
       )
-      response.original_hash.dig('data', 'Get', class_name)
+      response.original_hash.dig("data", "Get", class_name)
     rescue Graphlient::Errors::ExecutionError => error
       raise Weaviate::Error.new(error.response.data.get.errors.messages.to_h)
     end
@@ -53,7 +53,7 @@ def aggs(
         group_by: group_by,
         object_limit: object_limit
       )
-      response.original_hash.dig('data', 'Aggregate', class_name)
+      response.original_hash.dig("data", "Aggregate", class_name)
     rescue Graphlient::Errors::ExecutionError => error
       raise Weaviate::Error.new(error.response.data.aggregate.errors.messages.to_h)
     end
@@ -80,7 +80,7 @@ def explore(
         limit: limit,
         offset: offset
       )
-      response.original_hash.dig('data', 'Explore')
+      response.original_hash.dig("data", "Explore")
     rescue Graphlient::Errors::ExecutionError => error
       raise Weaviate::Error.new(error.to_s)
     end

lib/weaviate/schema.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'pry'
-
 module Weaviate
   class Schema < Base
     PATH = "schema"
@@ -49,16 +47,14 @@ def create(
       end
 
       if response.success?
-        response.body
-      else
-        response.body
       end
+      response.body
     end
 
     # Remove a class (and all data in the instances) from the schema.
     def delete(class_name:)
       response = client.connection.delete("#{PATH}/#{class_name}")
-      
+
       if response.success?
         response.body.empty?
       else
@@ -95,10 +91,8 @@ def update(
       end
 
       if response.success?
-        response.body
-      else
-        response.body
       end
+      response.body
     end
 
     # Add a property to an existing schema class.
@@ -111,10 +105,8 @@ def add_property(
       end
 
       if response.success?
-        response.body
-      else
-        response.body
       end
+      response.body
     end
 
     # Inspect the shards of a class

spec/weaviate/objects_spec.rb

@@ -33,7 +33,7 @@
           category: "philosophy"
         }
       )
-      expect(response.dig('class')).to eq('Question')
+      expect(response.dig("class")).to eq("Question")
     end
   end
 
@@ -53,7 +53,7 @@
   end
 
   describe "#exists?" do
-    let(:response) { OpenStruct.new(success?: true, status: 204, body: '') }
+    let(:response) { OpenStruct.new(success?: true, status: 204, body: "") }
 
     before do
       allow_any_instance_of(Faraday::Connection).to receive(:head)
@@ -84,7 +84,7 @@
         class_name: "Question",
         id: "123"
       )
-      expect(response.dig('class')).to eq('Question')
+      expect(response.dig("class")).to eq("Question")
     end
   end
 
@@ -147,7 +147,7 @@
           answer: "42"
         }
       )
-      expect(response.dig('class')).to eq('Question')
+      expect(response.dig("class")).to eq("Question")
     end
   end
 

spec/weaviate/schema_spec.rb

@@ -26,7 +26,7 @@
     end
 
     it "returns schemas" do
-      expect(schema.list.dig('classes').count).to eq(1)
+      expect(schema.list.dig("classes").count).to eq(1)
     end
   end
 
@@ -41,7 +41,7 @@
 
     it "returns the schema" do
       response = schema.get(class_name: "Question")
-      expect(response.dig('class')).to eq('Question')
+      expect(response.dig("class")).to eq("Question")
     end
   end
 
@@ -74,7 +74,7 @@
           }
         ]
       )
-      expect(response.dig('class')).to eq('Question')
+      expect(response.dig("class")).to eq("Question")
     end
   end
 
@@ -108,16 +108,13 @@
         class_name: "Question",
         description: "Information from a Wheel of Fortune question"
       )
-      expect(response.dig('class')).to eq('Question')
+      expect(response.dig("class")).to eq("Question")
     end
   end
 
   xdescribe "#add_property" do
-
-    
   end
 
-
   describe "#shards" do
     let(:response) { OpenStruct.new(success?: true, body: shard_fixture) }