dry up param detection and added spec for tool combiniation to ensure those are working correctly

Author: patvice

lib/ruby_llm/mcp/parameter.rb

@@ -7,6 +7,14 @@ module MCP
     class Parameter < RubyLLM::Parameter
       attr_accessor :items, :properties, :enum, :union_type, :default, :title
 
+      class << self
+        def all_mcp_parameters?(parameters)
+          parameters.is_a?(Hash) &&
+            parameters.any? &&
+            parameters.values.all? { |p| p.is_a?(RubyLLM::MCP::Parameter) }
+        end
+      end
+
       def initialize(name, type: "string", title: nil, desc: nil, required: true, default: nil, union_type: nil) # rubocop:disable Metrics/ParameterLists
         super(name, type: type.to_sym, desc: desc, required: required)
         @title = title

lib/ruby_llm/mcp/providers/anthropic/complex_parameter_support.rb

@@ -68,7 +68,7 @@ module RubyLLM::Providers::Anthropic::Tools
   module_function :original_clean_parameters, :original_required_parameters
 
   def clean_parameters(parameters)
-    if parameters.is_a?(Hash) && parameters.values.any? { |p| p.is_a?(RubyLLM::MCP::Parameter) }
+    if RubyLLM::MCP::Parameter.all_mcp_parameters?(parameters)
       return RubyLLM::MCP::Providers::Anthropic::ComplexParameterSupport.clean_parameters(parameters)
     end
 
@@ -77,7 +77,7 @@ def clean_parameters(parameters)
   module_function :clean_parameters
 
   def required_parameters(parameters)
-    if parameters.is_a?(Hash) && parameters.values.any? { |p| p.is_a?(RubyLLM::MCP::Parameter) }
+    if RubyLLM::MCP::Parameter.all_mcp_parameters?(parameters)
       return RubyLLM::MCP::Providers::Anthropic::ComplexParameterSupport.required_parameters(parameters)
     end
 

lib/ruby_llm/mcp/providers/gemini/complex_parameter_support.rb

@@ -76,7 +76,7 @@ module RubyLLM::Providers::Gemini::Tools
   module_function :param_type_for_gemini
 
   def format_parameters(parameters)
-    if parameters.is_a?(Hash) && parameters.values.all? { |p| p.is_a?(RubyLLM::MCP::Parameter) }
+    if RubyLLM::MCP::Parameter.all_mcp_parameters?(parameters)
       return RubyLLM::MCP::Providers::Gemini::ComplexParameterSupport.format_parameters(parameters)
     end