Possible bug; usize

[frankkienl]

usize is used here, instead of a specific size.
This will result in 4 or 8 bytes, depending on if the code is compiled on a 32bit or 64 bit system.
The JSON should be the same regardless of host architecture.

wled-json-api-library/src/structures/cfg/cfg_nw.rs

Line 27 in 87abb06

pub pskl: Option<usize>,

https://doc.rust-lang.org/std/primitive.usize.html

[paul-fornage]

Yes thank you for this I didn't realize that usize wasn't fixed when I made that.

Unfortunately the WLED code has changed much since I made this and I will probably be focusing efforts on making the WLED code follow a schema instead of git diffing and making this code match every update.

I think the odds are low that the field type in the WLED source is even the same as it was when I wrote the code.

[frankkienl]

Thanks for your reply!
I agree; With WLED changing constantly, it would be better to have a schema.
I'll have a look at the OpenAPI branch, and do my own experiments to double-check.

For extra context;
I was working on porting the Rust code to Kotlin;
As I'm planning on controlling WLED through a custom Android app.

I did find some 'strange' JSON api choices in WLED, that don't convert cleanly into Kotlin code;
For example; a Boolean, but you can also send "t" to toggle. So it can also be a String...

Quote from https://kno.wled.ge/interfaces/json-api/:

JSON key	Value range	Description
on	bool	On/Off state of the light. You can also use "t" instead of true or false to toggle.