feat: Replace element save buttons with SaveButton and enforce permissions (#470)

Author: paulgessinger

swift-paperless/Views/DocumentTypeEditView.swift

@@ -42,7 +42,7 @@ struct DocumentTypeEditView<Element>: View where Element: DocumentTypeProtocol {
     }
     .toolbar {
       ToolbarItem(placement: .navigationBarTrailing) {
-        Button(saveLabel) {
+        SaveButton(saveLabel) {
           do {
             try onSave?(element)
           } catch {

swift-paperless/Views/Settings/ManageView.swift

@@ -93,6 +93,7 @@ struct ManageView<Manager>: View where Manager: ManagerProtocol {
 
     var body: some View {
       Manager.EditView(element: element, onSave: onSaveInternal)
+        .disabled(!model.permissions.test(.change))
     }
   }
 
@@ -194,6 +195,9 @@ struct ManageView<Manager>: View where Manager: ManagerProtocol {
               NavigationLink {
                 Edit(model: model, element: element) { element in
                   guard model.permissions.test(.change) else {
+                    Logger.shared.info(
+                      "Silently not saving from edit view: this likely indicates a button is active that shouldn't be"
+                    )
                     return
                   }
 

swift-paperless/Views/StoragePathEditView.swift

@@ -50,7 +50,8 @@ struct StoragePathEditView<Element>: View where Element: StoragePathProtocol {
 
     .toolbar {
       ToolbarItem(placement: .navigationBarTrailing) {
-        Button(saveLabel) {
+
+        SaveButton(saveLabel) {
           do {
             try onSave?(storagePath)
           } catch {
@@ -71,15 +72,10 @@ extension StoragePathEditView where Element == ProtoStoragePath {
   }
 }
 
-struct EditStoragePath_Previews: PreviewProvider {
-  struct Container: View {
-    @State var path = ProtoStoragePath()
-    var body: some View {
-      StoragePathEditView(element: path, onSave: { _ in })
-    }
-  }
-
-  static var previews: some View {
-    Container()
+#Preview {
+  NavigationStack {
+    StoragePathEditView<ProtoStoragePath>(onSave: { _ in })
+      .navigationBarTitleDisplayMode(.inline)
+      .navigationTitle(Text(.localizable(.storagePathCreateTitle)))
   }
 }