Skip to content

Commit baa289a

Browse files
author
ergashev
committed
refactoring managers
1 parent d52fe61 commit baa289a

File tree

7 files changed

+17
-21
lines changed

7 files changed

+17
-21
lines changed

probetools/src/main/java/com/ebr163/probetools/Router.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
import com.ebr163.probetools.manager.BaseManager;
1010
import com.ebr163.probetools.manager.DBManager;
1111
import com.ebr163.probetools.manager.IndexManager;
12+
import com.ebr163.probetools.manager.ManagerFactory;
1213
import com.ebr163.probetools.manager.PreferencesManager;
1314
import com.ebr163.probetools.manager.TransitionManager;
14-
import com.ebr163.probetools.manager.util.ManagerFactory;
1515

1616
import java.util.ArrayList;
1717
import java.util.HashMap;
@@ -21,7 +21,7 @@
2121

2222
import fi.iki.elonen.NanoHTTPD;
2323

24-
public class Router {
24+
public final class Router {
2525

2626
private Map<Class<? extends BaseManager>, BaseManager> managers = new HashMap<>();
2727
private ManagerFactory managerFactory;

probetools/src/main/java/com/ebr163/probetools/manager/AssetsManager.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010

1111
import static fi.iki.elonen.NanoHTTPD.newChunkedResponse;
1212

13-
public class AssetsManager extends BaseManager {
13+
public final class AssetsManager extends BaseManager {
1414

1515
private final AssetManager assets;
1616
private final MimeTypeMap mymeTypesMap;
1717

18-
public AssetsManager(AssetManager assets) {
18+
AssetsManager(AssetManager assets) {
1919
this.assets = assets;
2020
mymeTypesMap = MimeTypeMap.getSingleton();
2121
}
@@ -29,7 +29,7 @@ public NanoHTTPD.Response asset(NanoHTTPD.IHTTPSession session) throws Exception
2929
}
3030
}
3131

32-
public NanoHTTPD.Response assetByPath(String path) throws IOException {
32+
NanoHTTPD.Response assetByPath(String path) throws IOException {
3333
final InputStream is = assets.open(path);
3434
return newChunkedResponse(NanoHTTPD.Response.Status.OK, getMymeType(path), is);
3535
}

probetools/src/main/java/com/ebr163/probetools/manager/DBManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@
1818

1919
import static fi.iki.elonen.NanoHTTPD.newChunkedResponse;
2020

21-
public class DBManager extends TransitionManager {
21+
public final class DBManager extends TransitionManager {
2222

2323
private static final String TABLE = "table";
2424
private static final String TITLE = "title";
2525
private static final String COLUMN = "column";
2626
private static final String DATA = "data";
2727
private String currentDatabase;
2828

29-
public DBManager(Context context) {
29+
DBManager(Context context) {
3030
this.context = context;
3131
}
3232

probetools/src/main/java/com/ebr163/probetools/manager/HttpInterceptManager.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
* Created by mac1 on 02.11.16.
55
*/
66

7-
public class HttpInterceptManager extends BaseManager {
8-
7+
final class HttpInterceptManager extends BaseManager {
98

9+
HttpInterceptManager() {
10+
}
1011
}

probetools/src/main/java/com/ebr163/probetools/manager/IndexManager.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@
88
* Created by mac1 on 02.11.16.
99
*/
1010

11-
public class IndexManager extends TransitionManager {
11+
public final class IndexManager extends TransitionManager {
12+
13+
IndexManager() {
14+
}
1215

1316
@Override
1417
public NanoHTTPD.Response transition(NanoHTTPD.IHTTPSession session) {

probetools/src/main/java/com/ebr163/probetools/manager/util/ManagerFactory.java renamed to probetools/src/main/java/com/ebr163/probetools/manager/ManagerFactory.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,12 @@
1-
package com.ebr163.probetools.manager.util;
1+
package com.ebr163.probetools.manager;
22

33
import android.content.Context;
44

5-
import com.ebr163.probetools.manager.AssetsManager;
6-
import com.ebr163.probetools.manager.BaseManager;
7-
import com.ebr163.probetools.manager.DBManager;
8-
import com.ebr163.probetools.manager.HttpInterceptManager;
9-
import com.ebr163.probetools.manager.IndexManager;
10-
import com.ebr163.probetools.manager.PreferencesManager;
11-
import com.ebr163.probetools.manager.TransitionManager;
12-
135
/**
146
* Created by mac1 on 02.11.16.
157
*/
168

17-
public class ManagerFactory {
9+
public final class ManagerFactory {
1810

1911
public <T> T build(Context context, Class<T> manager) {
2012
return (T) create(context, manager);

probetools/src/main/java/com/ebr163/probetools/manager/PreferencesManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
import fi.iki.elonen.NanoHTTPD;
1313

14-
public class PreferencesManager extends TransitionManager {
14+
public final class PreferencesManager extends TransitionManager {
1515

1616
public NanoHTTPD.Response loadAllPreferences(NanoHTTPD.IHTTPSession session) throws JSONException {
1717
Map<String, ?> params = getRouter().getPreferences().getAll();

0 commit comments

Comments
 (0)