Generate correct invalid patterns

pawankartik-elastic · pawankartik-elastic · commit 133a7c74e9cf · 2025-04-11T18:00:04.000+01:00
diff --git a/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java b/x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java
@@ -3119,7 +3119,8 @@ public void testInvalidPatternsWithIntermittentQuotes() {
         {
             var randomIndex = randomIndexPattern();
             // Select an invalid char to sneak in.
-            char[] invalidChars = { ' ', '/', '<', '>', '?', '|' };
+            // Note: some chars like '|' and '"' are excluded to generate a proper invalid name.
+            char[] invalidChars = { ' ', '/', '<', '>', '?' };
             var randomInvalidChar = invalidChars[randomIntBetween(0, invalidChars.length - 1)];
 
             // Construct the new invalid index pattern.

Original file line number	Diff line number	Diff line change
`@@ -3119,7 +3119,8 @@ public void testInvalidPatternsWithIntermittentQuotes() {`
`3119`	`3119`	`{`
`3120`	`3120`	`var randomIndex = randomIndexPattern();`
`3121`	`3121`	`// Select an invalid char to sneak in.`
`3122`		`- char[] invalidChars = { ' ', '/', '<', '>', '?', '\|' };`
	`3122`	`+ // Note: some chars like '\|' and '"' are excluded to generate a proper invalid name.`
	`3123`	`+ char[] invalidChars = { ' ', '/', '<', '>', '?' };`
`3123`	`3124`	`var randomInvalidChar = invalidChars[randomIntBetween(0, invalidChars.length - 1)];`
`3124`	`3125`
`3125`	`3126`	`// Construct the new invalid index pattern.`