Skip to content

Commit 80461af

Browse files
Set MRT when parsing instead of waiting for TSA
1 parent 10662e6 commit 80461af

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

server/src/main/java/org/elasticsearch/action/search/TransportSearchAction.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -353,10 +353,6 @@ private void executeRequest(
353353
Function<ActionListener<SearchResponse>, SearchPhaseProvider> searchPhaseProvider,
354354
boolean collectSearchTelemetry
355355
) {
356-
if (forceConnectTimeoutSecs != null) {
357-
original.setCcsMinimizeRoundtrips(true);
358-
}
359-
360356
final long relativeStartNanos = System.nanoTime();
361357
final SearchTimeProvider timeProvider = new SearchTimeProvider(
362358
original.getOrCreateAbsoluteStartMillis(),

server/src/main/java/org/elasticsearch/rest/action/search/RestSearchAction.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -244,13 +244,19 @@ public static void parseSearchRequest(
244244
if (searchRequest.pointInTimeBuilder() != null) {
245245
preparePointInTime(searchRequest, request);
246246
} else {
247-
if (inCpsContext.orElse(false) && request.hasParam("ccs_minimize_roundtrips")) {
248-
throw new IllegalArgumentException("Setting ccs_minimize_roundtrips is not supported in CPS context");
247+
if (inCpsContext.orElse(false)) {
248+
// We're in CPS environment. MRT should always be true and not be settable by the user.
249+
if (request.hasParam("ccs_minimize_roundtrips")) {
250+
throw new IllegalArgumentException("Setting ccs_minimize_roundtrips is not supported in CPS context");
251+
} else {
252+
searchRequest.setCcsMinimizeRoundtrips(true);
253+
}
254+
} else {
255+
// We're not in CPS environment, so parse what's in the request.
256+
searchRequest.setCcsMinimizeRoundtrips(
257+
request.paramAsBoolean("ccs_minimize_roundtrips", searchRequest.isCcsMinimizeRoundtrips())
258+
);
249259
}
250-
251-
searchRequest.setCcsMinimizeRoundtrips(
252-
request.paramAsBoolean("ccs_minimize_roundtrips", searchRequest.isCcsMinimizeRoundtrips())
253-
);
254260
}
255261
if (request.paramAsBoolean("force_synthetic_source", false)) {
256262
searchRequest.setForceSyntheticSource(true);

0 commit comments

Comments
 (0)