Skip to content

Commit 870facd

Browse files
authored
Remove partial aggregations (elastic#139143)
Partial aggregation was added to support mixing time-series and non-time-series aggregations in TS. Since we no longer support this, these can be removed.
1 parent f10268d commit 870facd

File tree

16 files changed

+10
-464
lines changed

16 files changed

+10
-464
lines changed

x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/DataType.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,8 @@
4141
* interact with in some way. This includes fully representable types (e.g.
4242
* {@link DataType#LONG}, numeric types which we promote (e.g. {@link DataType#SHORT})
4343
* or fold into other types (e.g. {@link DataType#DATE_PERIOD}) early in the
44-
* processing pipeline, types for internal use
45-
* cases (e.g. {@link DataType#PARTIAL_AGG}), and types which the language
46-
* doesn't support, but require special handling anyway (e.g.
47-
* {@link DataType#OBJECT})
44+
* processing pipeline, and types which the language doesn't support, but require
45+
* special handling anyway (e.g. {@link DataType#OBJECT})
4846
*
4947
* <h2>Process for adding a new data type</h2>
5048
* We assume that the data type is already supported in ES indices, but not in
@@ -359,12 +357,6 @@ public enum DataType implements Writeable {
359357
.docValues()
360358
.supportedSince(DataTypesTransportVersions.INDEX_SOURCE, DataTypesTransportVersions.INDEX_SOURCE)
361359
),
362-
/**
363-
* Fields with this type are the partial result of running a non-time-series aggregation
364-
* inside alongside time-series aggregations. These fields are not parsable from the
365-
* mapping and should be hidden from users.
366-
*/
367-
PARTIAL_AGG(builder().esType("partial_agg").estimatedSize(1024).supportedOnAllNodes()),
368360
AGGREGATE_METRIC_DOUBLE(
369361
builder().esType("aggregate_metric_double")
370362
.estimatedSize(Double.BYTES * 3 + Integer.BYTES)
@@ -665,7 +657,6 @@ public static boolean isRepresentable(DataType t) {
665657
&& t != SCALED_FLOAT
666658
&& t != SOURCE
667659
&& t != HALF_FLOAT
668-
&& t != PARTIAL_AGG
669660
&& t.isCounter() == false;
670661
}
671662

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/FromPartialAggregatorFunction.java

Lines changed: 0 additions & 103 deletions
This file was deleted.

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/FromPartialGroupingAggregatorFunction.java

Lines changed: 0 additions & 130 deletions
This file was deleted.

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/ToPartialAggregatorFunction.java

Lines changed: 0 additions & 85 deletions
This file was deleted.

0 commit comments

Comments
 (0)