Skip to content

Commit e540ac0

Browse files
Add overload that takes in a default value
1 parent 77807c4 commit e540ac0

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

server/src/main/java/org/elasticsearch/rest/action/search/RestSearchAction.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,9 @@ public static void parseSearchRequest(
274274
if (searchRequest.pointInTimeBuilder() != null) {
275275
preparePointInTime(searchRequest, request);
276276
} else {
277-
searchRequest.setCcsMinimizeRoundtrips(SearchParamsParser.parseCcsMinimizeRoundtrips(crossProjectEnabled, request));
277+
searchRequest.setCcsMinimizeRoundtrips(
278+
SearchParamsParser.parseCcsMinimizeRoundtrips(crossProjectEnabled, request, searchRequest.isCcsMinimizeRoundtrips())
279+
);
278280
}
279281
if (request.paramAsBoolean("force_synthetic_source", false)) {
280282
searchRequest.setForceSyntheticSource(true);

server/src/main/java/org/elasticsearch/rest/action/search/SearchParamsParser.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ public class SearchParamsParser {
2727
* @return A boolean that determines if round trips should be minimised for this search request.
2828
*/
2929
public static boolean parseCcsMinimizeRoundtrips(Optional<Boolean> crossProjectEnabled, RestRequest request) {
30+
return parseCcsMinimizeRoundtrips(crossProjectEnabled, request, true);
31+
}
32+
33+
public static boolean parseCcsMinimizeRoundtrips(Optional<Boolean> crossProjectEnabled, RestRequest request, boolean defaultValue) {
3034
if (crossProjectEnabled.orElse(false)) {
3135
if (request.hasParam("ccs_minimize_roundtrips")) {
3236
request.param("ccs_minimize_roundtrips");
@@ -38,7 +42,7 @@ public static boolean parseCcsMinimizeRoundtrips(Optional<Boolean> crossProjectE
3842
return true;
3943
} else {
4044
// This is not a CPS request; use the value the user has provided.
41-
return request.paramAsBoolean("ccs_minimize_roundtrips", true);
45+
return request.paramAsBoolean("ccs_minimize_roundtrips", defaultValue);
4246
}
4347
}
4448
}

0 commit comments

Comments
 (0)