Skip to content

Commit 244dc92

Browse files
committed
ignore non-zero return from lint
1 parent 3a539de commit 244dc92

File tree

4 files changed

+54
-18
lines changed

4 files changed

+54
-18
lines changed

dist/grading/builders/GradleBuilder.d.ts

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js

Lines changed: 26 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/grading/builders/GradleBuilder.ts

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,7 @@ import { parsePitestXml } from './pitest.js'
1111
import { processXMLResults } from './surefire.js'
1212

1313
export default class GradleBuilder extends Builder {
14-
async setupVenv(dir: string, key: string): Promise<void> {
15-
console.log('Venv not implemented in gradle builder')
16-
console.log('dir: ', dir)
17-
console.log('key: ', key)
18-
}
14+
async setupVenv(): Promise<void> {}
1915
async lint(): Promise<LintResult> {
2016
this.logger.log('hidden', 'Linting with Gradle')
2117
const { returnCode, output } = await this.executeCommandAndGetOutput(
@@ -61,7 +57,14 @@ export default class GradleBuilder extends Builder {
6157
this.logger.log('hidden', 'Testing with Gradle')
6258
const { returnCode } = await this.executeCommandAndGetOutput(
6359
'./gradlew',
64-
['--console=plain', 'test'],
60+
[
61+
'--console=plain',
62+
'test',
63+
'-x',
64+
'checkstyleMain',
65+
'-x',
66+
'checkstyleTest'
67+
],
6568
this.logger,
6669
timeoutSeconds,
6770
true
@@ -83,7 +86,14 @@ export default class GradleBuilder extends Builder {
8386
this.logger.log('hidden', 'Running Pitest')
8487
await this.executeCommandAndGetOutput(
8588
'./gradlew',
86-
['--console=plain', 'pitest'],
89+
[
90+
'--console=plain',
91+
'pitest',
92+
'-x',
93+
'checkstyleMain',
94+
'-x',
95+
'checkstyleTest'
96+
],
8797
this.logger,
8898
timeoutSeconds,
8999
false
@@ -111,7 +121,15 @@ export default class GradleBuilder extends Builder {
111121
this.logger.log('hidden', 'Building clean with Gradle')
112122
const { returnCode, output } = await this.executeCommandAndGetOutput(
113123
'./gradlew',
114-
['--console=plain', 'clean', '-x', 'test', 'build'],
124+
[
125+
'--console=plain',
126+
'clean',
127+
'-x',
128+
'checkstyleMain',
129+
'-x',
130+
'checkstyleTest',
131+
'build'
132+
],
115133
this.logger,
116134
timeoutSeconds,
117135
true

0 commit comments

Comments
 (0)