ignore gradle lint return code

Author: jon-bell

dist/grading/types.d.ts

@@ -31,7 +31,7 @@
           "additionalProperties": false,
           "properties": {
             "policy": {
-              "enum": ["fail", "warn", "ignore"],
+              "enum": ["fail", "ignore"],
               "type": "string"
             },
             "preset": {

dist/index.js

@@ -32,7 +32,7 @@ export default class GradleBuilder extends Builder {
       ],
       this.logger
     )
-    if (returnCode !== 0) {
+    if (returnCode !== 0 && returnCode !== 130) {
       throw new Error(
         `Unable to invoke Gradle checkstyle task. Here is the output that Gradle produced on the grading server: ${output}`
       )

dist/index.js.map

@@ -296,6 +296,22 @@ export class OverlayGrader extends Grader<OverlayPawtograderConfig> {
 
     console.log('Linting student submission')
     const lintResult = await this.builder.lint()
+    if (this.config.build.linter?.policy === 'fail') {
+      if (lintResult.status === 'fail') {
+        this.logger.log(
+          'visible',
+          `Linting failed, submission can not be graded. Please fix the above errors below and resubmit. This submission will not count towards any submisison limits (if applicable for this assignment).`
+        )
+        this.logger.log('visible', lintResult.output)
+        return {
+          lint: lintResult,
+          output: this.logger.getEachOutput(),
+          tests: [],
+          score: 0,
+          artifacts: []
+        }
+      }
+    }
 
     console.log('Resetting to run instructor tests on student submission')
     await this.resetSolutionFiles()

pawtograder.schema.json

@@ -35,7 +35,7 @@ export interface BuildConfig {
   artifacts?: GraderArtifact[]
   linter?: {
     preset: 'checkstyle'
-    policy: 'fail' | 'warn' | 'ignore'
+    policy: 'fail' | 'ignore'
   }
   student_tests?: {
     student_impl?: {