Address PR feedback on CSV escaping and E2E parsing

Co-authored-by: Jonathan Bell <jon@jonbell.net>

Author: cursoragent

app/course/[course_id]/manage/gradebook/gradebookTable.tsx

@@ -1842,14 +1842,17 @@ export default function GradebookTable() {
     const csv = gradebookController.exportGradebook(courseController, {
       useRenderExpressions: exportWithRenderExpressions
     });
-    const blob = new Blob(
-      [
-        csv
-          .map((row) => row.map((cell) => (typeof cell === "string" ? `"${cell.replace(/"/g, "")}"` : cell)).join(","))
-          .join("\n")
-      ],
-      { type: "text/csv" }
-    );
+    const csvText = csv
+      .map((row) =>
+        row
+          .map((cell) => {
+            const stringCell = cell === null || cell === undefined ? "" : String(cell);
+            return `"${stringCell.replace(/"/g, '""')}"`;
+          })
+          .join(",")
+      )
+      .join("\n");
+    const blob = new Blob([csvText], { type: "text/csv" });
     const url = URL.createObjectURL(blob);
     const a = document.createElement("a");
     a.href = url;

tests/e2e/TestingUtils.ts

@@ -387,10 +387,8 @@ async function signInWithMagicLinkAndRetry(page: Page, testingUser: TestingUser,
     }
     throw new Error(`Magic link sign-in did not complete (final URL: ${page.url()})`);
   } catch (error) {
-    if (retriesRemaining > 0 && (error as Error).message.includes("did not complete")) {
-      return await signInWithMagicLinkAndRetry(page, testingUser, retriesRemaining - 1);
-    }
-    throw new Error(`Failed to sign in with magic link: ${(error as Error).message}`);
+    const message = error instanceof Error ? error.message : String(error);
+    throw new Error(`Failed to sign in with magic link: ${message}`);
   }
 }
 export async function loginAsUser(page: Page, testingUser: TestingUser, course?: Course) {

tests/e2e/gradebook.test.tsx

@@ -4,6 +4,7 @@ import type { Page, Locator } from "@playwright/test";
 import { argosScreenshot } from "@argos-ci/playwright";
 import dotenv from "dotenv";
 import { promises as fs } from "node:fs";
+import Papa from "papaparse";
 import {
   createClass,
   createUsersInClass,
@@ -51,10 +52,14 @@ async function readCellText(page: Page, rowName: string, columnName: string) {
 }
 
 function parseCsv(csvText: string) {
-  return csvText
-    .trim()
-    .split(/\r?\n/)
-    .map((line) => line.split(",").map((cell) => cell.trim().replace(/^"(.*)"$/, "$1")));
+  const parsed = Papa.parse<string[]>(csvText, {
+    skipEmptyLines: true
+  });
+  if (parsed.errors.length > 0) {
+    const firstError = parsed.errors[0];
+    throw new Error(`Failed to parse CSV: ${firstError.message}`);
+  }
+  return parsed.data.map((row) => row.map((cell) => cell ?? ""));
 }
 
 function getCsvCellValue(csvRows: string[][], email: string, columnName: string) {