Switch to raise over Rails.logger

[ogirginc]

At the moment of creating this discussion, Rails.logger is being used in 8 files. Since raise has been extensively used already, would it be OK for me to create a PR to replace Rails.logger with raises?

For example, it took us ages to find out that an admin created a customer via our admin panel, which seems to fail to trigger #pay_customer:

pay/app/jobs/pay/customer_sync_job.rb

Line 6 in ec4e870

Rails.logger.info "Couldn't find a Pay::Customer with ID = #{pay_customer_id}"

If raise was used in this part, it would make catching this error trivial. Also, CustomerSyncJob seems too critical to not to raise anything.

What do you think? Agreed or not? If not, any suggestions to handle the rescue logic? Thanks! :)

[excid3]

No, we don't want debug logging to raise errors.

[ogirginc]

Thanks for the reply! :) Other than monkey patching, do have any recommendations to track failed CustomerSyncJobs?

[excid3]

You can monitor your logs, but it's only going to be queued up for IDs that exist, see:

pay/lib/pay/billable/sync_customer.rb

Line 23 in ec4e870

pay_customers.pluck(:id).each do |pay_customer_id|

The only reason this would fail is if the pay customer was deleted after syncing, so in that case you want it to ignore it.