Granting credits on invoice.paid — out-of-order webhooks and missing subscription

[cercxtrova]

Hi everyone, thanks for this gem.

I’m using Rails 8 with Pay (only with Stripe) and SolidQueue.
In my app, I grant credits to users when an invoice.paid event comes in.

It works great in development, but in production I’ve noticed something odd: sometimes the invoice.paid webhook arrives before the customer.subscription.created event.
When that happens, the related Pay::Subscription doesn’t exist in the database yet, so my code can’t find it to retrieve the user.
If I resend the same event from the Stripe Dashboard a few seconds later, it works perfectly — the subscription has been created by then.

I know Stripe doesn’t guarantee webhook order, so that part makes sense.

What I’m not sure about is the best way to handle it. Would you consider it reasonable to rely on invoice.paid for granting credits, and if the subscription isn’t found yet, do something like:

def subscription
  @_subscription ||= begin
    Pay::Subscription.find_by(processor_id: subscription_id) ||
      begin
        Pay::Stripe::Subscription.sync(subscription_id)
        Pay::Subscription.find_by(processor_id: subscription_id)
      end
  end
end

Does this seem like the right solution to you?
Thanks!

[excid3]

Yep, you're on the right track!

The sync will ensure you get the up-to-date data on the Stripe Subscription, so you may want to just always sync it. sync will also return the subscription so you could just do:

pay_subscription = Pay::Stripe::Subscription.sync(subscription_id)

[cercxtrova]

Awesome, thank you @excid3 !