Upgrade docs around Stripe charge attributes unclear

[fschwahn]

I'm currently upgrading pay, and I've seen this in the changelog, but not in the Upgrade-docs:

[Breaking] Moved Stripe charge attributes to pay_charge.stripe_invoice to simplify integrations and provide access to more data

This requires re-syncing Pay charges and subscriptions to update the cached data. Receipts and invoices expect to be able to access these details in the new format. We recommend syncing records either in task after deployment or before the data is displayed in a request.

I'm coming from a pre-object version, so I don't have any objects synced in production right now, but everything is still in data. In that case, do I need to pro-actively sync subscriptions / charges, or will that happen automatically when accessing the object if it is missing?

[excid3]

It happens automatically for subscriptions, see: df14c6d

I probably need to add that to Charges too. Edit: done!

You can also do it proactively which I would recommend just to backfill everything.

Pay::Stripe::Charge.find_each { it.sync! }
Pay::Stripe::Subscription.find_each { it.sync! }

[fschwahn]

Great, thanks. That makes rolling out this upgrade much easier as I don't need to worry about access while the backfill-task is still running.

The UPGRADE-document is a bit confusing at the moment, as it includes some breaking changes, but not all. The existence of the document lead me to believe it is enough to read it to perform the upgrade, but in fact I had to check the CHANGELOG too for a myriad of other breaking changes. Maybe at least a general disclaimer to also check the CHANGELOG for other breaking changes would improve things?