Pay::Subscription stripe_object-data may be outdated

[fschwahn]

I'm using stripe_object&.latest_invoice (for a Pay::Stripe::Subscription) to look at the latest invoice (and check if it has been paid). However, this object may be stale, ie. it may have been already paid, but the stored invoice still has status == 'open'.

I'm not sure if this is a bug (and the subscription should be updated along with the invoice), or I should not have relied on the latest_invoice being up-to-date, but introduced a bug into our system which was easy to add, and hard to detect.

[excid3]

Webhooks for invoices should update that? We may need to add more.

[fschwahn]

No, webhooks didn't do that. Note that this happened for an invoice which is paid after sending the invoice. The only events pay picks up are payment_intent.succeeded and charge.succeeded, but those don't update the Subscription. Possibly we would have to also act on invoice.payment_succeeded, and sync the subscription.

[excid3]

Yeah I think we just need to add a couple more webhook listeners for invoices and we should be set.

[BrandonCzaja]

I'm interested in working on this. I'll create an Issue for it.

[BrandonCzaja]

Hi @fschwahn. Here is the new Issue. Can you please confirm it accurately describes the issue? Thank you.

[fschwahn]

Looks accurate 👍