Change from_id return type to Self

`from_id` does not fail so it shouldn't return an `Result`.

Author: arminsabouri

payjoin-cli/src/app/v2/mod.rs

@@ -114,7 +114,7 @@ impl AppTrait for App {
                             .expect("Receiver pubkey should exist if session id exists");
                         if session_receiver_pubkey == *receiver_pubkey {
                             let sender_persister =
-                                SenderPersister::from_id(self.db.clone(), session_id).ok()?;
+                                SenderPersister::from_id(self.db.clone(), session_id);
                             let (send_session, _) = replay_sender_event_log(&sender_persister)
                                 .map_err(|e| anyhow!("Failed to replay sender event log: {:?}", e))
                                 .ok()?;
@@ -190,7 +190,7 @@ impl AppTrait for App {
 
         for session_id in recv_session_ids {
             let self_clone = self.clone();
-            let recv_persister = ReceiverPersister::from_id(self.db.clone(), session_id)?;
+            let recv_persister = ReceiverPersister::from_id(self.db.clone(), session_id);
             let receiver_state = replay_receiver_event_log(&recv_persister)
                 .map_err(|e| anyhow!("Failed to replay receiver event log: {:?}", e))?
                 .0;
@@ -200,7 +200,7 @@ impl AppTrait for App {
         }
 
         for session_id in send_session_ids {
-            let sender_persiter = SenderPersister::from_id(self.db.clone(), session_id)?;
+            let sender_persiter = SenderPersister::from_id(self.db.clone(), session_id);
             let sender_state = replay_sender_event_log(&sender_persiter)
                 .map_err(|e| anyhow!("Failed to replay sender event log: {:?}", e))?
                 .0;

payjoin-cli/src/db/v2.rs

@@ -36,9 +36,7 @@ impl SenderPersister {
         Ok(Self { db, session_id: SessionId(session_id) })
     }
 
-    pub fn from_id(db: Arc<Database>, id: SessionId) -> crate::db::Result<Self> {
-        Ok(Self { db, session_id: id })
-    }
+    pub fn from_id(db: Arc<Database>, id: SessionId) -> Self { Self { db, session_id: id } }
 }
 
 impl SessionPersister for SenderPersister {
@@ -117,9 +115,7 @@ impl ReceiverPersister {
         Ok(Self { db, session_id: SessionId(session_id) })
     }
 
-    pub fn from_id(db: Arc<Database>, id: SessionId) -> crate::db::Result<Self> {
-        Ok(Self { db, session_id: id })
-    }
+    pub fn from_id(db: Arc<Database>, id: SessionId) -> Self { Self { db, session_id: id } }
 }
 
 impl SessionPersister for ReceiverPersister {