Bump MSRV to 1.85.0 (#957)

Closes #954

Following the rest of the ecosystem we are bumping rust-payjoin to an
msrv of 1.85.0.

Any actual code changes / improvements beyond lint failures caused by
the upgrade will come in a follow-up PR

Author: spacebear21

.github/workflows/rust.yml

@@ -9,7 +9,7 @@ jobs:
       fail-fast: false
       matrix:
         rust:
-          - 1.63.0 # MSRV
+          - 1.85.0 # MSRV
           - stable
           - nightly
     env:

README.md

@@ -12,7 +12,7 @@
     <a href="https://docs.rs/payjoin"><img alt="Crates" src="https://img.shields.io/static/v1?logo=read-the-docs&label=docs.rs&message=payjoin&color=f75390"></a>
     <a href="https://github.com/payjoin/rust-payjoin/actions/workflows/rust.yml"><img alt="CI Status" src="https://github.com/payjoin/rust-payjoin/actions/workflows/rust.yml/badge.svg"></a>
     <a href="https://coveralls.io/github/payjoin/rust-payjoin?branch=master"><img src="https://coveralls.io/repos/github/payjoin/rust-payjoin/badge.svg?branch=master"/></a>
-    <a href="https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html"><img alt="Rustc Version 1.63.0+" src="https://img.shields.io/badge/rustc-1.63.0%2B-lightgrey.svg"/></a>
+    <a href="https://blog.rust-lang.org/2025/02/20/Rust-1.85.0/"><img alt="Rustc Version 1.85.0+" src="https://img.shields.io/badge/rustc-1.85.0%2B-lightgrey.svg"/></a>
   </p>
 
   <h4>
@@ -101,7 +101,7 @@ Seeking review of the code that verifies there is no overpayment. Contributions
 
 ## Minimum Supported Rust Version (MSRV)
 
-The `payjoin` library and `payjoin-cli` should always compile with any combination of features on Rust **1.63.0**.
+The `payjoin` library and `payjoin-cli` should always compile with any combination of features on Rust **1.85.0**.
 
 To build and test with the MSRV you will need to pin the below dependency versions:
 

flake.nix

@@ -25,7 +25,7 @@
           overlays = [rust-overlay.overlays.default];
         };
 
-        msrv = "1.63.0";
+        msrv = "1.85.0";
         rustVersions = with pkgs.rust-bin;
           builtins.mapAttrs (_name: rust-bin:
             rust-bin.override {

payjoin-cli/Cargo.toml

@@ -9,7 +9,7 @@ keywords = ["bip78", "payjoin", "bitcoin"]
 categories = ["cryptography::cryptocurrencies", "network-programming"]
 license = "MITNFA"
 edition = "2021"
-rust-version = "1.63"
+rust-version = "1.85"
 resolver = "2"
 exclude = ["tests"]
 

payjoin-directory/Cargo.toml

@@ -9,7 +9,7 @@ keywords = ["bip78", "bip77", "payjoin", "bitcoin", "ohttp"]
 categories = ["cryptography::cryptocurrencies", "network-programming"]
 license = "MITNFA"
 edition = "2021"
-rust-version = "1.63"
+rust-version = "1.85"
 resolver = "2"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

payjoin-test-utils/Cargo.toml

@@ -5,7 +5,7 @@ edition = "2021"
 authors = ["Dan Gould <d@ngould.dev>"]
 description = "Payjoin test utilities"
 repository = "https://github.com/payjoin/rust-payjoin"
-rust-version = "1.63"
+rust-version = "1.85"
 license = "MIT"
 
 [dependencies]

payjoin/Cargo.toml

@@ -10,7 +10,7 @@ categories = ["api-bindings", "cryptography::cryptocurrencies", "network-program
 license = "MITNFA"
 resolver = "2"
 edition = "2021"
-rust-version = "1.63"
+rust-version = "1.85"
 exclude = ["tests"]
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

payjoin/src/core/send/v1.rs

@@ -354,7 +354,7 @@ mod test {
         // invalid
         let mut invalid_utf8_padding = PAYJOIN_PROPOSAL.as_bytes().to_vec();
         invalid_utf8_padding
-            .extend(std::iter::repeat(0x00).take(MAX_CONTENT_LENGTH - invalid_utf8_padding.len()));
+            .extend(std::iter::repeat_n(0x00, MAX_CONTENT_LENGTH - invalid_utf8_padding.len()));
 
         let ctx = create_v1_context();
         let response = ctx.process_response(&invalid_utf8_padding);
@@ -375,7 +375,7 @@ mod test {
     #[test]
     fn process_response_invalid_buffer_len() {
         let mut data = PAYJOIN_PROPOSAL.as_bytes().to_vec();
-        data.extend(std::iter::repeat(0).take(MAX_CONTENT_LENGTH + 1));
+        data.extend(std::iter::repeat_n(0, MAX_CONTENT_LENGTH + 1));
 
         let ctx = create_v1_context();
         let response = ctx.process_response(&data);