Skip to content

Conversation

@benalleng
Copy link
Collaborator

This will remove nix caching, this also will serve as a way to observe how long the action takes without caching.

This is as a result of some out of band discussion with regards to the CI time.

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls
Copy link
Collaborator

coveralls commented Jan 16, 2026

Pull Request Test Coverage Report for Build 21147895725

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 96 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.3%) to 83.357%

Files with Coverage Reduction New Missed Lines %
payjoin/src/core/receive/v2/session.rs 7 98.78%
payjoin/src/core/send/v2/session.rs 11 96.36%
payjoin/src/core/send/v2/mod.rs 26 90.03%
payjoin/src/core/receive/v2/mod.rs 52 90.94%
Totals Coverage Status
Change from base Build 21044982881: 0.3%
Covered Lines: 9937
Relevant Lines: 11921

💛 - Coveralls

@benalleng benalleng requested a review from spacebear21 January 16, 2026 15:27
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

For what it's worth this latest run https://github.com/payjoin/rust-payjoin/actions/runs/21080158957/job/60631686262?pr=1232 took roughly as long as the one in this PR. It looks like the cache was failing to initialize anyways, so I'm in favor of removing it until we find out a working solution.

@benalleng benalleng changed the title Remove nix caching on flake check CI Remove nix caching on flake checks Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants