fix(plugin-multi-tenant): remove unused syncTenants from useEffect deps (#14362)

sealan · web-flow · commit 906a3dc8e9d2 · 2025-10-27T09:18:34.000-04:00
https://discord.com/channels/967097582721572934/1004009734115966976/1425988296835858523 ## Change Fixes infinite loop bug in the multi-tenant plugin: `WatchTenantCollection` component causes repeated API calls to `/api/tenants/populate-tenant-options` in admin. <img width="1800" height="765" alt="image" src="https://github.com/user-attachments/assets/715541d6-5075-47eb-97f0-ce0a516d5141" /> ## Fix Remove `syncTenants` from the first useEffect dependency array.
diff --git a/packages/plugin-multi-tenant/src/components/WatchTenantCollection/index.tsx b/packages/plugin-multi-tenant/src/components/WatchTenantCollection/index.tsx
@@ -41,7 +41,7 @@ export const WatchTenantCollection = () => {
     if (id && titleField?.initialValue) {
       void syncTenantTitle()
     }
-  }, [id, titleField?.initialValue, syncTenants])
+  }, [id, titleField?.initialValue])
 
   React.useEffect(() => {
     if (operation === 'create' && submitted) {

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ export const WatchTenantCollection = () => {`
`41`	`41`	`if (id && titleField?.initialValue) {`
`42`	`42`	`void syncTenantTitle()`
`43`	`43`	`}`
`44`		`- }, [id, titleField?.initialValue, syncTenants])`
	`44`	`+ }, [id, titleField?.initialValue])`
`45`	`45`
`46`	`46`	`React.useEffect(() => {`
`47`	`47`	`if (operation === 'create' && submitted) {`