Skip to content

Commit f2d4004

Browse files
fix(ui): incorrect padding when using rtl (#13338)
Fixes inconsistent padding in the doc view for RTL viewing. ### ❌ Before #### Desktop <img width="1331" height="310" alt="CleanShot 2025-07-30 at 16 37 30" src="https://github.com/user-attachments/assets/48d3e127-09dd-4356-99ae-16fe47817937" /> #### Mobile <img width="619" height="328" alt="CleanShot 2025-07-30 at 16 37 52" src="https://github.com/user-attachments/assets/36169ca5-c1a2-4175-a6e1-f0a4784d5e9e" /> ### ✅ After #### Desktop <img width="1675" height="291" alt="CleanShot 2025-07-30 at 16 39 18" src="https://github.com/user-attachments/assets/1da78a8a-b236-4f95-9eb2-8b5055b676ae" /> #### Mobile <img width="531" height="309" alt="CleanShot 2025-07-30 at 16 39 30" src="https://github.com/user-attachments/assets/af858bfc-6d75-4139-ada1-4f8100744bfb" />
1 parent 8a48941 commit f2d4004

File tree

2 files changed

+41
-18
lines changed

2 files changed

+41
-18
lines changed

packages/ui/src/elements/DocumentControls/index.scss

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,12 @@
187187
}
188188
}
189189

190+
&__popup {
191+
[dir='rtl'] & {
192+
padding-left: var(--gutter-h);
193+
}
194+
}
195+
190196
&__meta {
191197
width: auto;
192198
gap: calc(var(--base) / 2);
@@ -216,7 +222,9 @@
216222
}
217223

218224
&__controls {
219-
padding-left: var(--gutter-h);
225+
[dir='ltr'] & {
226+
padding-left: var(--gutter-h);
227+
}
220228
overflow: auto;
221229

222230
// do not show scrollbar because the parent container has a static height

packages/ui/src/elements/DocumentFields/index.scss

Lines changed: 32 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,24 @@
55
width: 100%;
66
display: flex;
77
--doc-sidebar-width: 325px;
8+
--sidebar-gutter-h-right: var(--gutter-h);
9+
--sidebar-gutter-h-left: calc(var(--base) * 2);
10+
--main-gutter-h-left: var(--gutter-h);
11+
--main-gutter-h-right: calc(var(--base) * 2);
12+
13+
[dir='rtl'] &:not(&--force-sidebar-wrap) {
14+
--sidebar-gutter-h-left: var(--gutter-h);
15+
--sidebar-gutter-h-right: calc(var(--base) * 2);
16+
--main-gutter-h-left: calc(var(--base) * 2);
17+
--main-gutter-h-right: var(--gutter-h);
18+
}
19+
20+
&--force-sidebar-wrap {
21+
--sidebar-gutter-h-left: var(--gutter-h);
22+
--sidebar-gutter-h-right: var(--gutter-h);
23+
--main-gutter-h-left: var(--gutter-h);
24+
--main-gutter-h-right: var(--gutter-h);
25+
}
826

927
&--has-sidebar {
1028
.document-fields {
@@ -13,18 +31,18 @@
1331
}
1432

1533
&__edit {
34+
padding-left: var(--main-gutter-h-left);
35+
padding-right: var(--main-gutter-h-right);
1636
[dir='ltr'] & {
1737
top: 0;
1838
right: 0;
1939
border-right: 1px solid var(--theme-elevation-100);
20-
padding-right: calc(var(--base) * 2);
2140
}
2241

2342
[dir='rtl'] & {
2443
top: 0;
2544
left: 0;
2645
border-left: 1px solid var(--theme-elevation-100);
27-
padding-left: calc(var(--base) * 2);
2846
}
2947
}
3048

@@ -74,8 +92,8 @@
7492
flex-direction: column;
7593
gap: var(--base);
7694
padding-top: calc(var(--base) * 1.5);
77-
padding-left: calc(var(--base) * 2);
78-
padding-right: var(--gutter-h);
95+
padding-left: var(--sidebar-gutter-h-left);
96+
padding-right: var(--sidebar-gutter-h-right);
7997
padding-bottom: var(--spacing-view-bottom);
8098
}
8199

@@ -106,14 +124,23 @@
106124

107125
&__sidebar-fields {
108126
padding-top: 0;
109-
padding-left: var(--gutter-h);
110127
padding-bottom: 0;
111128
}
112129
}
113130
}
114131

115132
@include mid-break {
116133
display: block;
134+
[dir='rtl'] &:not(&--force-sidebar-wrap) {
135+
--sidebar-gutter-h-left: var(--gutter-h);
136+
--sidebar-gutter-h-right: var(--gutter-h);
137+
--main-gutter-h-left: var(--gutter-h);
138+
--main-gutter-h-right: var(--gutter-h);
139+
}
140+
--main-gutter-h-left: var(--gutter-h);
141+
--main-gutter-h-right: var(--gutter-h);
142+
--sidebar-gutter-h-left: var(--gutter-h);
143+
--sidebar-gutter-h-right: var(--gutter-h);
117144

118145
&--has-sidebar {
119146
.document-fields {
@@ -124,12 +151,10 @@
124151
&__edit {
125152
[dir='ltr'] & {
126153
border-right: 0;
127-
padding-right: var(--gutter-h);
128154
}
129155

130156
[dir='rtl'] & {
131157
border-left: 0;
132-
padding-left: var(--gutter-h);
133158
}
134159
}
135160

@@ -160,18 +185,8 @@
160185

161186
&__sidebar-fields {
162187
padding-top: 0;
163-
padding-left: var(--gutter-h);
164-
padding-right: var(--gutter-h);
165188
padding-bottom: 0;
166189
gap: base(0.5);
167-
168-
[dir='ltr'] & {
169-
padding-right: var(--gutter-h);
170-
}
171-
172-
[dir='rtl'] & {
173-
padding-left: var(--gutter-h);
174-
}
175190
}
176191

177192
&__sidebar {

0 commit comments

Comments
 (0)