Pagination and limit work independently

[geminigeek]

Bug Report

currently there is no way to get n records while pagination is false , ( can not use with limit with pagination =false) , it seems limit and pagination are coupled.

Current Behavior

this query works

 const records = await req.payload.find({
            collection: "genres",
            where: {},
            pagination: true,
            limit: 1,
            
          })

result

{
"records": {
"docs": [
{
"id": "631a14f6cd00fd4c5fbca500",
"genre": "game-show",
"onFly": false
}
],
"totalDocs": 30,
"limit": 1,
"totalPages": 30,
"page": 1,
"pagingCounter": 1,
"hasPrevPage": false,
"hasNextPage": true,
"prevPage": null,
"nextPage": 2
}
}

Expected Behavior

this query should also work, but it pulls all records ?

const records = await req.payload.find({
            collection: "genres",
            where: {},
            pagination: false,
            limit: 1,
            
          })

result

{
"records": {
"docs": [
{
"id": "631a14f6cd00fd4c5fbca500",
"genre": "game-show",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4fe",
"genre": "short",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4fc",
"genre": "adult",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4fa",
"genre": "talk-show",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4f8",
"genre": "reality-tv",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4f6",
"genre": "film-noir",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4f4",
"genre": "news",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4f2",
"genre": "sport",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4f0",
"genre": "musical",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4ee",
"genre": "sci-fi",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4ec",
"genre": "biography",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4ea",
"genre": "western",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4e8",
"genre": "war",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4e6",
"genre": "thriller",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4e4",
"genre": "tv movie",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4e2",
"genre": "science fiction",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4e0",
"genre": "romance",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4de",
"genre": "mystery",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4dc",
"genre": "music",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4da",
"genre": "horror",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4d8",
"genre": "history",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4d6",
"genre": "fantasy",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4d4",
"genre": "family",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4d2",
"genre": "drama",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4d0",
"genre": "documentary",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4ce",
"genre": "crime",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4cc",
"genre": "comedy",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4ca",
"genre": "animation",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4c8",
"genre": "adventure",
"onFly": false
},
{
"id": "631a14f6cd00fd4c5fbca4c6",
"genre": "action",
"onFly": false
}
],
"totalDocs": 1,
"limit": 1,
"totalPages": 1,
"page": 1,
"pagingCounter": 1,
"hasPrevPage": false,
"hasNextPage": false,
"prevPage": null,
"nextPage": null
}
}

Possible Solution

Decouple pagination and limit

Steps to Reproduce

Detailed Description

[jmikrut]

Yes, this is actually working by design. Disabling pagination also removes the limit completely. But I think that we could probably extend this as a new feature. Let me convert this into a Discussion and mark it as planned, and we'll get on it!

[geminigeek]

hi,

i can see you guys have tagged it as "roadmap-priority-1" , kindly check this a comment in previous discussion , if we can incorporate this also in the same PR if possible.

#1030 (reply in thread)

thanks for an excellent software

[geminigeek]

Hi,

thanks for the feature. you guys are super awesome

[JarrodMFlesch]

Thank you for the report!