Feature Request: Support useTempFile for express-fileupload

[BitPatty]

Bug Report

To avoid excessive memory usage for uploads useTempFiles for express-fileupload can be enabled in the payload config. This of course flushes the buffer on the req.files.file object on which payload is relying for resizing.

Expected Behavior

useTempFiles should not affect payloads upload mechanic.

Current Behavior

Payload fails to process the image since it expects the whole image to be in a buffer.

Possible Solution

Check whether the temp file exists and do further processing based on this structure.

• Resizes images should also not be kept as a buffer if useTempFiles is true. Depending on the source file and resizing options the memory usage is a real concern.

Steps to Reproduce

1. upload.useTempFiles to true in the payload config
2. Upload an image

Detailed Description

Payload 0.19.2

payload/src/uploads/uploadFile.ts

Lines 59 to 87 in cac5266

	const fsSafeName = !overwriteExistingFiles ? await getSafeFileName(Model, staticPath, file.name) : file.name;
	try {
	if (!disableLocalStorage) {
	await saveBufferToFile(file.data, `${staticPath}/${fsSafeName}`);
	}
	fileData.filename = fsSafeName;
	fileData.filesize = file.size;
	fileData.mimeType = file.mimetype || mime.getType(fsSafeName);
	if (isImage(file.mimetype)) {
	const dimensions = await getImageSize(file);
	fileData.width = dimensions.width;
	fileData.height = dimensions.height;
	if (Array.isArray(imageSizes) && file.mimetype !== 'image/svg+xml') {
	req.payloadUploadSizes = {};
	fileData.sizes = await resizeAndSave({
	req,
	file: file.data,
	dimensions,
	staticPath,
	config: collectionConfig,
	savedFilename: fsSafeName,
	mimeType: fileData.mimeType,
	});
	}
	}

[denolfe]

Hey @BitPatty , thanks for the report. Since we used express-fileupload's TS type for upload, it looks like this feature would be supported in Payload. However, this feature is not intended to be supported.

I think this would be a great enhancement, though. I'll move this to discussions as a feature request.

[BitPatty]

Is there an existing "built-in" way to override the whole upload function and/or the resizing mechanic?

Currently, the beforeChange hook is triggered too late to intervene and express-fileupload has no extension points either.