fix: misplaced @swc/core dependency in create-payload-app
#14360
+36
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainpi
force-pushed
the
fix-misplaced-devdep
branch
from
38ef69a to
6895cc0
Compare
romainpi
changed the title
create-payload-app
romainpi
force-pushed
the
fix-misplaced-devdep
branch
from
6895cc0 to
dfc49c6
Compare
`@swc/core` should be placed in `devDependencies` See: https://swc.rs/docs/getting-started#installation
romainpi
force-pushed
the
fix-misplaced-devdep
branch
from
f726dc9 to
71540e7
Compare
|
We need swc installed to parse through the AST of your next config, thus it needs to be in |
|
@AlessioGr those are only type imports, only required by the ts compiler, not required by the js runtime! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Correct me if I'm wrong, but shouldn't
@swc/corebe placed indevDependencies?https://swc.rs/docs/getting-started#installation