fix(drizzle): skip foreign key for blocks that are shared across collections #14395
Conversation
technicaldirector
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where foreign keys were incorrectly created for blocks that are shared across collections. The fix identifies blocks with custom database names and skips creating the parent ID foreign key for them.
- Adds logic to detect blocks with custom database names that indicate shared usage across collections
- Conditionally creates foreign keys only for non-shared blocks
- Prevents database constraint errors for shared block configurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const baseForeignKeys: Record<string, RawForeignKey> = { | ||
| _parentIdFk: { | ||
| // Skip creating a parent_id foreign key for blocks that are shared across collections (have a custom dbName) | ||
| const hasCustomDbName = block.dbName !== undefined && block.dbName !== null |
There was a problem hiding this comment.
Consider using a more concise nullish coalescing check. The condition can be simplified to block.dbName != null which checks for both undefined and null in a single comparison.
| const hasCustomDbName = block.dbName !== undefined && block.dbName !== null | |
| const hasCustomDbName = block.dbName != null |
There was a problem hiding this comment.
I wonder if you have tried to use Block References for this case and if that feature doesn't work here we should fix it.
I don't think that this PR is a good solution since just checking for block.dbName does not really tell us that this block is shared across collections. Additionally, it'd cause a schema regression for every block that has dbName with removing a foreign key.
If we really want to check if a block is "shared", we'd have to traverse fields of every collection and see if we can find at least 2 the same JS references to that block.
If I remember correctly I tried it with Block referneces and received the same problem. In addition to that block references had the problem that when you have a custom field with imports these haven't been added to the import map. |
|
Yes - just confirmed it. Same issue when using blockReferences |
2 participants
Fixes #14350