Merge pull request #309 from paynl/feature/PLUG-5017-2

PLUG-5017 - MSI remove legacy function

Author: woutse

Observer/SubtractInventoryObserver.php

@@ -4,7 +4,6 @@
 
 use Magento\Framework\Event\Observer as EventObserver;
 use Magento\Framework\Event\ObserverInterface;
-use Magento\CatalogInventory\Api\StockRegistryInterface;
 use Magento\Store\Api\StoreRepositoryInterface;
 use Magento\InventorySales\Model\ResourceModel\GetAssignedStockIdForWebsite\Proxy as GetAssignedStockIdForWebsiteProxy;
 use Magento\InventoryReservationsApi\Model\ReservationBuilderInterface\Proxy as ReservationBuilderInterfaceProxy;
@@ -32,31 +31,23 @@ class SubtractInventoryObserver implements ObserverInterface
      */
     private $appendReservations;
 
-    /**
-     * @var StockRegistryInterface
-     */
-    private $stockRegistry;
-
     /**
      * SubtractInventoryObserver constructor.
      * @param StoreRepositoryInterface $storeRepository
      * @param GetAssignedStockIdForWebsiteProxy $getAssignedStockIdForWebsite
      * @param ReservationBuilderInterfaceProxy $reservationBuilder
      * @param AppendReservationsInterfaceProxy $appendReservations
-     * @param StockRegistryInterface $stockRegistry
      */
     public function __construct(
         StoreRepositoryInterface $storeRepository,
         GetAssignedStockIdForWebsiteProxy $getAssignedStockIdForWebsite,
         ReservationBuilderInterfaceProxy $reservationBuilder,
-        AppendReservationsInterfaceProxy $appendReservations,
-        StockRegistryInterface $stockRegistry
+        AppendReservationsInterfaceProxy $appendReservations
     ) {
         $this->storeRepository = $storeRepository;
         $this->getAssignedStockIdForWebsite = $getAssignedStockIdForWebsite;
         $this->reservationBuilder = $reservationBuilder;
         $this->appendReservations = $appendReservations;
-        $this->stockRegistry = $stockRegistry;
     }
 
     /**
@@ -80,7 +71,6 @@ public function execute(EventObserver $observer)
             $storeId = $order->getStoreId();
             $website = $this->storeRepository->getById($storeId)->getWebsite();
             $websiteCode = $website->getCode();
-            $websiteId = $website->getId();
 
             if (
                 interface_exists(\Magento\InventoryReservationsApi\Model\ReservationBuilderInterface::class)
@@ -105,21 +95,7 @@ interface_exists(\Magento\InventoryReservationsApi\Model\ReservationBuilderInter
                 }
 
                 $this->appendReservations->execute($reservations);
-            } else {
-                foreach ($order->getAllItems() as $item) {
-                    $itemData = $item->getData();
-
-                    $itemQty = $itemData['qty_ordered'] ?? null;
-                    $itemSku = $itemData['sku'] ?? null;
-
-                    $stockItem = $this->stockRegistry->getStockItemBySku($itemSku, $websiteId);
-                    $currentQty = (float) $stockItem->getQty();
-                    $stockItem->setQty($currentQty - $itemQty);
-                    $stockItem->setIsInStock((($currentQty - $itemQty) > 0) ? 1 : 0);
-                    $this->stockRegistry->updateStockItemBySku($itemSku, $stockItem);
-                }
             }
-
             $order->setInventoryProcessed(true)->save();
             return $this;
         }