Skip to content

Commit 8f938f5

Browse files
addresses comments
1 parent 7da92bb commit 8f938f5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/components/modal/v2/lib/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ export function validateProps(updatedProps) {
145145

146146
export function sendEventAck(eventId, trustedOrigin) {
147147
// skip this step if running in test env because jest's target windows don't support postMessage
148-
if (window.process?.env?.NODE_ENV === 'test') {
148+
if (process.env.NODE_ENV === 'test') {
149149
return;
150150
}
151151

src/components/modal/v2/lib/zoid-polyfill.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ export function validateAndUpdateBrowserProps(initialProps, propListeners, updat
1818
origin: eventOrigin,
1919
data: { eventName, id, eventPayload: newProps }
2020
} = updatedPropsEvent;
21-
const merchantOrigin = decodeURIComponent(initialProps.origin);
21+
const clientOrigin = decodeURIComponent(initialProps.origin);
2222

23-
if (eventOrigin === merchantOrigin && eventName === 'PROPS_UPDATE' && newProps && typeof newProps === 'object') {
23+
if (eventOrigin === clientOrigin && eventName === 'PROPS_UPDATE' && newProps && typeof newProps === 'object') {
2424
// send event ack so PostMessenger will stop reposting event
25-
sendEventAck(id, merchantOrigin);
25+
sendEventAck(id, clientOrigin);
2626
const validProps = validateProps(newProps);
2727
listenAndAssignProps(validProps, propListeners);
2828
}

0 commit comments

Comments
 (0)