Merge pull request #100 from MarkusPoutanen/fix-item-vat-validation

Item: Add validation for empty vatPercentage

Author: kotivuori

src/Model/Item.php

@@ -388,6 +388,9 @@ public function validate()
         if ($props['units'] < 0) {
             throw new ValidationException('Items units can\'t be a negative number');
         }
+        if ($props['vatPercentage'] === null) {
+            throw new ValidationException('Item vatPercentage is empty');
+        }
         if ($props['vatPercentage'] < 0) {
             throw new ValidationException('Items vatPercentage can\'t be a negative number');
         }

tests/Model/ItemTest.php

@@ -57,6 +57,17 @@ public function testItemWithNegativeUnitsThrowsError()
             ->validate();
     }
 
+    public function testItemWithoutVatThrowsError()
+    {
+        $this->expectException(ValidationException::class);
+        (new Item())->setUnitPrice(1)
+            ->setUnits(2)
+            ->setStamp('thisIsStamp')
+            ->setProductCode('productCode123')
+            ->setDescription('description')
+            ->validate();
+    }
+
     public function testItemWIthNegativeVatThrowsError()
     {
         $this->expectException(ValidationException::class);