Skip to content

Commit 1b65f53

Browse files
committed
PipeCommand: pass shell arg to ExternalCommand.
Prior to this branch, `shell=True` was passed to Popen regardless of whether `--shell` was passed. I'm not sure why this was the case but it wasn't a problem. Now that we're passing to ExternalCommand, this doesn't work because ExternalCommand does it's own manipulation of cmd when shell=False which is incompatible with a list-style cmd.
1 parent 60b1142 commit 1b65f53

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

alot/commands/thread.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -793,7 +793,7 @@ def callback(out):
793793

794794
await ui.apply_command(ExternalCommand(cmd,
795795
stdin=mail,
796-
shell=True,
796+
shell=self.shell,
797797
thread=self.background,
798798
on_success=callback))
799799

0 commit comments

Comments
 (0)