Update external command error message.

This message could now display for several different external commands
besides editor.

Author: ryneeverett

alot/commands/globals.py

@@ -312,9 +312,10 @@ async def apply(self, ui):
             if self.on_success is not None:
                 self.on_success(out)
         else:
-            msg = "editor has exited with error code {} -- {}".format(
+            msg = (
+                "external command has exited with error code {} -- {}".format(
                     "None" if proc is None else proc.returncode,
-                    ret or "No stderr output")
+                    ret or "No stderr output"))
             ui.notify(msg, priority='error')
         if self.refocus and callerbuffer in ui.buffers:
             logging.info('refocussing')

tests/commands/test_global.py

@@ -105,6 +105,9 @@ def test_get_template_decode(self):
 
 
 class TestExternalCommand(unittest.TestCase):
+    NO_STDERR_MSG = (
+        'external command has exited with error code 1 -- No stderr output'
+    )
 
     @utilities.async_test
     async def test_no_spawn_no_stdin_success(self):
@@ -126,9 +129,7 @@ async def test_no_spawn_no_stdin_attached(self):
         ui = utilities.make_ui()
         cmd = g_commands.ExternalCommand('test -p /dev/stdin', refocus=False)
         await cmd.apply(ui)
-        ui.notify.assert_called_once_with(
-                'editor has exited with error code 1 -- No stderr output',
-                priority='error')
+        ui.notify.assert_called_once_with(self.NO_STDERR_MSG, priority='error')
 
     @utilities.async_test
     async def test_no_spawn_stdin_attached(self):
@@ -143,9 +144,7 @@ async def test_no_spawn_failure(self):
         ui = utilities.make_ui()
         cmd = g_commands.ExternalCommand('false', refocus=False)
         await cmd.apply(ui)
-        ui.notify.assert_called_once_with(
-                'editor has exited with error code 1 -- No stderr output',
-                priority='error')
+        ui.notify.assert_called_once_with(self.NO_STDERR_MSG, priority='error')
 
     @utilities.async_test
     @mock.patch(
@@ -177,9 +176,7 @@ async def test_spawn_failure(self):
         ui = utilities.make_ui()
         cmd = g_commands.ExternalCommand('false', refocus=False, spawn=True)
         await cmd.apply(ui)
-        ui.notify.assert_called_once_with(
-                'editor has exited with error code 1 -- No stderr output',
-                priority='error')
+        ui.notify.assert_called_once_with(self.NO_STDERR_MSG, priority='error')
 
 
 class TestCallCommand(unittest.TestCase):