Catching panic in ref location when ref is crazy.

Signed-off-by: Dave Shanley <[email protected]>

Author: daveshanley

paths/paths_test.go

@@ -577,3 +577,27 @@ paths:
 
     assert.Len(t, errs, 1)
 }
+
+func TestNewValidator_PostMatch_Error(t *testing.T) {
+
+    spec := `openapi: 3.1.0
+paths:
+  /pizza/{cakes}:
+    post:
+      operationId: locateBurger
+      parameters:
+        - name: cakes
+          in: path
+          required: true
+          schema:
+            type: string`
+
+    doc, _ := libopenapi.NewDocument([]byte(spec))
+    m, _ := doc.BuildV3Model()
+
+    request, _ := http.NewRequest(http.MethodPost, "https://things.com/pizza/1234", nil)
+
+    _, errs, _ := FindPath(request, &m.Model)
+
+    assert.Len(t, errs, 1)
+}

schema_validation/locate_schema_property.go

@@ -12,15 +12,26 @@ import (
 // LocateSchemaPropertyNodeByJSONPath will locate a schema property node by a JSONPath. It converts something like
 // #/components/schemas/MySchema/properties/MyProperty to something like $.components.schemas.MySchema.properties.MyProperty
 func LocateSchemaPropertyNodeByJSONPath(doc *yaml.Node, JSONPath string) *yaml.Node {
-    // first convert the path to something we can use as a lookup, remove the leading slash
-    _, path := utils.ConvertComponentIdIntoFriendlyPathSearch(JSONPath)
-    if path == "" {
-        return nil
-    }
-    yamlPath, _ := yamlpath.NewPath(path)
-    locatedNodes, _ := yamlPath.Find(doc)
-    if len(locatedNodes) > 0 {
-        return locatedNodes[0]
-    }
-    return nil
+    var locatedNode *yaml.Node
+    doneChan := make(chan bool)
+    go func() {
+        defer func() {
+            if err := recover(); err != nil {
+                // can't search path, too crazy.
+                doneChan <- true
+            }
+        }()
+        _, path := utils.ConvertComponentIdIntoFriendlyPathSearch(JSONPath)
+        if path == "" {
+            doneChan <- true
+        }
+        yamlPath, _ := yamlpath.NewPath(path)
+        locatedNodes, _ := yamlPath.Find(doc)
+        if len(locatedNodes) > 0 {
+            locatedNode = locatedNodes[0]
+        }
+        doneChan <- true
+    }()
+    <-doneChan
+    return locatedNode
 }

schema_validation/validate_document.go

@@ -42,6 +42,7 @@ func ValidateOpenAPIDocument(doc libopenapi.Document) (bool, []*errors.Validatio
             if er.Error != "" {
 
                 // locate the violated property in the schema
+
                 located := LocateSchemaPropertyNodeByJSONPath(info.RootNode.Content[0], er.KeywordLocation)
                 if located == nil {
                     // try again with the instance location