fix failing test with missed error handling.

Also bumped the version of the golangci-lint tool

Author: daveshanley

.github/workflows/build.yaml

@@ -24,7 +24,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v8
         with:
-          version: v2.1
+          version: v2.7
   build:
     name: Build
     runs-on: ubuntu-latest

requests/validate_request.go

@@ -76,8 +76,33 @@ func ValidateRequestSchema(input *ValidateRequestSchemaInput) (bool, []*errors.V
 	// Cache miss or no cache - render and compile
 	if compiledSchema == nil {
 		renderCtx := base.NewInlineRenderContext()
-		renderedSchema, _ = input.Schema.RenderInlineWithContext(renderCtx)
+		var renderErr error
+		renderedSchema, renderErr = input.Schema.RenderInlineWithContext(renderCtx)
 		referenceSchema = string(renderedSchema)
+
+		// If rendering failed (e.g., circular reference), return the render error
+		if renderErr != nil {
+			violation := &errors.SchemaValidationFailure{
+				Reason:          renderErr.Error(),
+				Location:        "schema rendering",
+				ReferenceSchema: referenceSchema,
+			}
+			validationErrors = append(validationErrors, &errors.ValidationError{
+				ValidationType:    helpers.RequestBodyValidation,
+				ValidationSubType: helpers.Schema,
+				Message: fmt.Sprintf("%s request body for '%s' failed schema rendering",
+					input.Request.Method, input.Request.URL.Path),
+				Reason: fmt.Sprintf("The request schema failed to render: %s",
+					renderErr.Error()),
+				SpecLine:               1,
+				SpecCol:                0,
+				SchemaValidationErrors: []*errors.SchemaValidationFailure{violation},
+				HowToFix:               "check the request schema for circular references or invalid structures",
+				Context:                referenceSchema,
+			})
+			return false, validationErrors
+		}
+
 		jsonSchema, _ = utils.ConvertYAMLtoJSON(renderedSchema)
 
 		var err error

requests/validate_request_test.go

@@ -234,3 +234,44 @@ func indentLines(s string, indent string) string {
 	}
 	return strings.Join(lines, "\n")
 }
+
+func TestValidateRequestSchema_CircularReference(t *testing.T) {
+	// Test when schema has a circular reference that causes render failure
+	spec := `openapi: 3.1.0
+info:
+  title: Test
+  version: 1.0.0
+components:
+  schemas:
+    Error:
+      type: object
+      properties:
+        code:
+          type: string
+        details:
+          type: array
+          items:
+            $ref: '#/components/schemas/Error'`
+
+	doc, err := libopenapi.NewDocument([]byte(spec))
+	require.NoError(t, err)
+	model, errs := doc.BuildV3Model()
+	require.Empty(t, errs)
+
+	// Verify circular reference was detected
+	require.Len(t, model.Index.GetCircularReferences(), 1)
+
+	schema := model.Model.Components.Schemas.GetOrZero("Error")
+	require.NotNil(t, schema)
+
+	valid, errors := ValidateRequestSchema(&ValidateRequestSchemaInput{
+		Request: postRequestWithBody(`{"code": "abc", "details": [{"code": "def"}]}`),
+		Schema:  schema.Schema(),
+		Version: 3.1,
+	})
+
+	assert.False(t, valid)
+	require.Len(t, errors, 1)
+	assert.Contains(t, errors[0].Message, "failed schema rendering")
+	assert.Contains(t, errors[0].Reason, "circular reference")
+}

responses/validate_response.go

@@ -79,8 +79,33 @@ func ValidateResponseSchema(input *ValidateResponseSchemaInput) (bool, []*errors
 	// Cache miss or no cache - render and compile
 	if compiledSchema == nil {
 		renderCtx := base.NewInlineRenderContext()
-		renderedSchema, _ = input.Schema.RenderInlineWithContext(renderCtx)
+		var renderErr error
+		renderedSchema, renderErr = input.Schema.RenderInlineWithContext(renderCtx)
 		referenceSchema = string(renderedSchema)
+
+		// If rendering failed (e.g., circular reference), return the render error
+		if renderErr != nil {
+			violation := &errors.SchemaValidationFailure{
+				Reason:          renderErr.Error(),
+				Location:        "schema rendering",
+				ReferenceSchema: referenceSchema,
+			}
+			validationErrors = append(validationErrors, &errors.ValidationError{
+				ValidationType:    helpers.ResponseBodyValidation,
+				ValidationSubType: helpers.Schema,
+				Message: fmt.Sprintf("%d response body for '%s' failed schema rendering",
+					input.Response.StatusCode, input.Request.URL.Path),
+				Reason: fmt.Sprintf("The response schema for status code '%d' failed to render: %s",
+					input.Response.StatusCode, renderErr.Error()),
+				SpecLine:               1,
+				SpecCol:                0,
+				SchemaValidationErrors: []*errors.SchemaValidationFailure{violation},
+				HowToFix:               "check the response schema for circular references or invalid structures",
+				Context:                referenceSchema,
+			})
+			return false, validationErrors
+		}
+
 		jsonSchema, _ = utils.ConvertYAMLtoJSON(renderedSchema)
 
 		var err error

responses/validate_response_test.go

@@ -249,3 +249,45 @@ func TestValidateResponseSchema_NilSchemaGoLow(t *testing.T) {
 	assert.Equal(t, "schema cannot be rendered", errors[0].Message)
 	assert.Contains(t, errors[0].Reason, "does not have low-level information")
 }
+
+func TestValidateResponseSchema_CircularReference(t *testing.T) {
+	// Test when schema has a circular reference that causes render failure
+	spec := `openapi: 3.1.0
+info:
+  title: Test
+  version: 1.0.0
+components:
+  schemas:
+    Error:
+      type: object
+      properties:
+        code:
+          type: string
+        details:
+          type: array
+          items:
+            $ref: '#/components/schemas/Error'`
+
+	doc, err := libopenapi.NewDocument([]byte(spec))
+	require.NoError(t, err)
+	model, errs := doc.BuildV3Model()
+	require.Empty(t, errs)
+
+	// Verify circular reference was detected
+	require.Len(t, model.Index.GetCircularReferences(), 1)
+
+	schema := model.Model.Components.Schemas.GetOrZero("Error")
+	require.NotNil(t, schema)
+
+	valid, errors := ValidateResponseSchema(&ValidateResponseSchemaInput{
+		Request:  postRequest(),
+		Response: responseWithBody(`{"code": "abc", "details": [{"code": "def"}]}`),
+		Schema:   schema.Schema(),
+		Version:  3.1,
+	})
+
+	assert.False(t, valid)
+	require.Len(t, errors, 1)
+	assert.Contains(t, errors[0].Message, "failed schema rendering")
+	assert.Contains(t, errors[0].Reason, "circular reference")
+}