- Address review comments

Author: JemDay

config/config.go

@@ -24,7 +24,6 @@ func NewValidationOptions(opts ...Option) *ValidationOptions {
 
 	// Apply any supplied overrides
 	for _, opt := range opts {
-		// Sanity
 		if opt != nil {
 			opt(o)
 		}

helpers/schema_compiler.go

@@ -11,8 +11,8 @@ import (
 
 // ConfigureCompiler configures a JSON Schema compiler with the desired behavior.
 func ConfigureCompiler(c *jsonschema.Compiler, o *config.ValidationOptions) {
-	// Sanity
 	if o == nil {
+		// Sanity
 		return
 	}
 

helpers/schema_compiler_test.go

@@ -73,7 +73,7 @@ func Test_ValidJSONSchemaWithInvalidContent(t *testing.T) {
 
 	jsch, err := NewCompiledSchema("test", []byte(badSchema), nil)
 
-	assert.NotNil(t, err, "Expected an error to be thrown")
+	assert.NoError(t, err, "Expected an error to be thrown")
 	assert.Nil(t, jsch, "invalid schema compiled!")
 }
 
@@ -87,7 +87,7 @@ func Test_MalformedSONSchema(t *testing.T) {
 
 	jsch, err := NewCompiledSchema("test", []byte(badSchema), nil)
 
-	assert.NotNil(t, err, "Expected an error to be thrown")
+	assert.NoError(t, err, "Expected an error to be thrown")
 	assert.Nil(t, jsch, "invalid schema compiled!")
 }
 
@@ -108,6 +108,6 @@ func Test_ValidJSONSchemaWithIncompleteContent(t *testing.T) {
 
 	jsch, err := NewCompiledSchema("test", []byte(incompleteSchema), nil)
 
-	assert.NotNil(t, err, "Expected an error to be thrown")
+	assert.NoError(t, err, "Expected an error to be thrown")
 	assert.Nil(t, jsch, "invalid schema compiled!")
 }

parameters/query_parameters_test.go

@@ -761,7 +761,7 @@ paths:
 
 	valid, errors := v.ValidateQueryParams(request)
 	assert.True(t, valid)
-	assert.Len(t, errors, 0)
+	assert.Empty(t, errors)
 }
 
 func TestNewValidator_QueryParamInvalidDateFormat(t *testing.T) {
@@ -813,7 +813,7 @@ paths:
 
 	valid, errors := v.ValidateQueryParams(request)
 	assert.True(t, valid)
-	assert.Len(t, errors, 0)
+	assert.Empty(t, errors)
 }
 
 func TestNewValidator_QueryParamInvalidDateTimeFormat(t *testing.T) {