fixed linting issues

Author: daveshanley

errors/parameter_errors.go

@@ -150,8 +150,7 @@ func IncorrectQueryParamArrayBoolean(
 	}
 }
 
-func IncorrectParamArrayMaxNumItems(
-	param *v3.Parameter, sch *base.Schema, expected, actual int64) *ValidationError {
+func IncorrectParamArrayMaxNumItems(param *v3.Parameter, sch *base.Schema, expected, actual int64) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationQuery,
@@ -165,8 +164,7 @@ func IncorrectParamArrayMaxNumItems(
 	}
 }
 
-func IncorrectParamArrayMinNumItems(
-	param *v3.Parameter, sch *base.Schema, expected, actual int64) *ValidationError {
+func IncorrectParamArrayMinNumItems(param *v3.Parameter, sch *base.Schema, expected, actual int64) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationQuery,
@@ -180,8 +178,7 @@ func IncorrectParamArrayMinNumItems(
 	}
 }
 
-func IncorrectParamArrayUniqueItems(
-	param *v3.Parameter, sch *base.Schema, duplicates string) *ValidationError {
+func IncorrectParamArrayUniqueItems(param *v3.Parameter, sch *base.Schema, duplicates string) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationQuery,

parameters/query_parameters.go

@@ -21,6 +21,10 @@ import (
 	"github.com/pb33f/libopenapi-validator/paths"
 )
 
+const rx = `[:\/\?#\[\]\@!\$&'\(\)\*\+,;=]`
+
+var rxRxp = regexp.MustCompile(rx)
+
 func (v *paramValidator) ValidateQueryParams(request *http.Request) (bool, []*errors.ValidationError) {
 	pathItem, errs, foundPath := paths.FindPath(request, v.document)
 	if len(errs) > 0 {
@@ -29,9 +33,6 @@ func (v *paramValidator) ValidateQueryParams(request *http.Request) (bool, []*er
 	return v.ValidateQueryParamsWithPathItem(request, pathItem, foundPath)
 }
 
-var rx = `[:\/\?#\[\]\@!\$&'\(\)\*\+,;=]`
-var rxRxp = regexp.MustCompile(rx)
-
 func (v *paramValidator) ValidateQueryParamsWithPathItem(request *http.Request, pathItem *v3.PathItem, pathValue string) (bool, []*errors.ValidationError) {
 	if pathItem == nil {
 		return false, []*errors.ValidationError{{

parameters/query_parameters_test.go

@@ -3172,9 +3172,7 @@ paths:
 	// Helper to build a request
 	makeRequest := func(ids []string) *http.Request {
 		values := make([]string, len(ids))
-		for i, id := range ids {
-			values[i] = fmt.Sprintf("%s", id)
-		}
+		copy(values, ids)
 		req, _ := http.NewRequest(http.MethodGet, "/items?id="+strings.Join(values, ","), nil)
 		return req
 	}

parameters/validation_functions.go

@@ -161,7 +161,6 @@ func ValidateQueryArray(
 
 		// for each type defined in the item's schema, check the item
 		for _, itemType := range itemsSchema.Type {
-
 			switch itemType {
 			case helpers.Integer, helpers.Number:
 				if _, err := strconv.ParseFloat(item, 64); err != nil {