Fixed locking issue,

The property counts were off causing a deadlock.

Author: daveshanley

what-changed/model/schema.go

@@ -546,7 +546,6 @@ func buildProperty(lProps, rProps []string, lEntities, rEntities map[string]*bas
 		}
 		for w := range rProps {
 			if lEntities[rProps[w]] != nil {
-				totalProperties++
 				go checkProperty(rProps[w], lEntities[rProps[w]], rEntities[rProps[w]], propChanges, doneChan)
 			} else {
 				CreateChange(changes, ObjectAdded, v3.PropertiesLabel,
@@ -571,7 +570,6 @@ func buildProperty(lProps, rProps []string, lEntities, rEntities map[string]*bas
 		// now check if anything was removed
 		for w := range lProps {
 			if rEntities[lProps[w]] != nil {
-				totalProperties++
 				go checkProperty(lProps[w], rEntities[lProps[w]], lEntities[rProps[w]], propChanges, doneChan)
 			} else {
 				CreateChange(changes, ObjectRemoved, v3.PropertiesLabel,

what-changed/model/schema_test.go

@@ -3185,3 +3185,50 @@ components:
 	}
 
 }
+
+func TestCompareSchemas_TestSchemaLockIssue(t *testing.T) {
+	left := `openapi: 3.1.0
+components:
+  schemas:
+    CompanyInformation:
+      description: |
+        Provides information about Company
+      type: object
+      properties:
+        companyName:
+          type: string
+          maxLength: 100
+        website:
+          type: string
+          maxLength: 1024
+`
+
+	right := `openapi: 3.1.0
+components:
+  schemas:
+    CompanyInformation:
+      description: |
+        Provides information about Company
+      type: object
+      properties:
+        companyName:
+          type: string
+          maxLength: 100
+        website:
+          type: string
+          maxLength: 1024
+        extraField:
+          type: string
+          maxLength: 1024`
+
+	leftDoc, rightDoc := test_BuildDoc(left, right)
+
+	// extract left reference schema and non reference schema.
+	lSchemaProxy := leftDoc.Components.Value.FindSchema("CompanyInformation").Value
+	rSchemaProxy := rightDoc.Components.Value.FindSchema("CompanyInformation").Value
+
+	changes := CompareSchemas(lSchemaProxy, rSchemaProxy)
+	assert.NotNil(t, changes)
+	assert.Equal(t, 1, changes.TotalChanges())
+
+}