[net] fix downloads no longer working after the recent GitHub server update

* GitHub appears to have updated their HTTP servers to enable gzip compression when requested.
* Unfortunately, the default from Rufus was to attempt to use compression where possible
  (ironically in an effort to save GitHub some bandwidth), which doesn't seem to sit too well
  with Windows' HttpQueryInfoA(HTTP_QUERY_CONTENT_LENGTH) API, as it errors out on trying to
  produce the content-length *DESPITE* the field being reported by GitHub in the HTTP header.
* As a result, we switch all HTTP downloads *not* to try to use compression by forcing
  "Accept-Encoding: identity".
* Unfortunately, besides affecting the download of resources such as GRUB/Syslinux ones, it
  also affects the ability to look for updates, which means that NONE of the version of Rufus
  prior to 4.9 (outside of the Windows Store ones) will be able to find that there exists a
  newer version to update to... :(
* Closes #2756.

Author: pbatard

src/net.c

@@ -59,7 +59,6 @@ extern BOOL is_x86_64;
 extern USHORT NativeMachine;
 static DWORD error_code, fido_len = 0;
 static BOOL force_update_check = FALSE;
-static const char* request_headers[2] = { "Accept-Encoding: none", "Accept-Encoding: gzip, deflate" };
 extern const char* efi_archname[ARCH_MAX];
 
 #if defined(__MINGW32__)
@@ -175,7 +174,7 @@ uint64_t DownloadToFileOrBufferEx(const char* url, const char* file, const char*
 	const char* short_name;
 	unsigned char buf[DOWNLOAD_BUFFER_SIZE];
 	char hostname[64], urlpath[128], strsize[32];
-	BOOL r = FALSE, use_github_api;
+	BOOL r = FALSE;
 	DWORD dwSize, dwWritten, dwDownloaded;
 	HANDLE hFile = INVALID_HANDLE_VALUE;
 	HINTERNET hSession = NULL, hConnection = NULL, hRequest = NULL;
@@ -227,18 +226,16 @@ uint64_t DownloadToFileOrBufferEx(const char* url, const char* file, const char*
 		goto out;
 	}
 
-	// If we are querying the GitHub API, we need to enable raw content and
-	// set 'Accept-Encoding' to 'none' to get the data length.
-	use_github_api = (strstr(url, "api.github.com") != NULL);
-	if (use_github_api && !HttpAddRequestHeadersA(hRequest, "Accept: application/vnd.github.v3.raw",
-		(DWORD)-1, HTTP_ADDREQ_FLAG_ADD)) {
+	// If we are querying the GitHub API, we need to enable raw content
+	if (strstr(url, "api.github.com") != NULL && !HttpAddRequestHeadersA(hRequest,
+		"Accept: application/vnd.github.v3.raw", (DWORD)-1, HTTP_ADDREQ_FLAG_ADD)) {
 		uprintf("Unable to enable raw content from GitHub API: %s", WindowsErrorString());
 		goto out;
 	}
-	if (!HttpSendRequestA(hRequest, request_headers[use_github_api ? 0 : 1], -1L, NULL, 0)) {
-		uprintf("Unable to send request: %s", WindowsErrorString());
-		goto out;
-	}
+	// Must use "Accept-Encoding: identity" to get the file size
+	// This is needed for GitHub as the Microsoft HTTP APIs can't seem to read content-length for
+	// compressed content from GitHub, and using "identity" disables compression.
+	HttpSendRequestA(hRequest, "Accept-Encoding: identity", -1L, NULL, 0);
 
 	// Get the file size
 	dwSize = sizeof(DownloadStatus);
@@ -643,10 +640,12 @@ static DWORD WINAPI CheckForUpdatesThread(LPVOID param)
 				INTERNET_FLAG_IGNORE_REDIRECT_TO_HTTP | INTERNET_FLAG_IGNORE_REDIRECT_TO_HTTPS |
 				INTERNET_FLAG_NO_COOKIES | INTERNET_FLAG_NO_UI | INTERNET_FLAG_NO_CACHE_WRITE | INTERNET_FLAG_HYPERLINK |
 				((UrlParts.nScheme == INTERNET_SCHEME_HTTPS) ? INTERNET_FLAG_SECURE : 0), (DWORD_PTR)NULL);
-			if ((hRequest == NULL) || (!HttpSendRequestA(hRequest, request_headers[1], -1L, NULL, 0))) {
+			if (hRequest == NULL) {
 				uprintf("Unable to send request: %s", WindowsErrorString());
 				goto out;
 			}
+			// Must use "Accept-Encoding: identity" to get the file size
+			HttpSendRequestA(hRequest, "Accept-Encoding: identity", -1L, NULL, 0);
 
 			// Ensure that we get a text file
 			dwSize = sizeof(dwStatus);
@@ -1010,8 +1009,8 @@ BOOL IsDownloadable(const char* url)
 	if (hRequest == NULL)
 		goto out;
 
-	if (!HttpSendRequestA(hRequest, request_headers[1], -1L, NULL, 0))
-		goto out;
+	// Must use "Accept-Encoding: identity" to get the file size
+	HttpSendRequestA(hRequest, "Accept-Encoding: identity", -1L, NULL, 0);
 
 	// Get the file size
 	dwSize = sizeof(DownloadStatus);

src/rufus.rc

@@ -33,7 +33,7 @@ LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL
 IDD_DIALOG DIALOGEX 12, 12, 232, 326
 STYLE DS_SETFONT | DS_MODALFRAME | DS_CENTER | WS_MINIMIZEBOX | WS_POPUP | WS_CAPTION | WS_SYSMENU
 EXSTYLE WS_EX_ACCEPTFILES
-CAPTION "Rufus 4.9.2254"
+CAPTION "Rufus 4.9.2255"
 FONT 9, "Segoe UI Symbol", 400, 0, 0x0
 BEGIN
     LTEXT           "Drive Properties",IDS_DRIVE_PROPERTIES_TXT,8,6,53,12,NOT WS_GROUP
@@ -407,8 +407,8 @@ END
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 4,9,2254,0
- PRODUCTVERSION 4,9,2254,0
+ FILEVERSION 4,9,2255,0
+ PRODUCTVERSION 4,9,2255,0
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -426,13 +426,13 @@ BEGIN
             VALUE "Comments", "https://rufus.ie"
             VALUE "CompanyName", "Akeo Consulting"
             VALUE "FileDescription", "Rufus"
-            VALUE "FileVersion", "4.9.2254"
+            VALUE "FileVersion", "4.9.2255"
             VALUE "InternalName", "Rufus"
             VALUE "LegalCopyright", "� 2011-2025 Pete Batard (GPL v3)"
             VALUE "LegalTrademarks", "https://www.gnu.org/licenses/gpl-3.0.html"
             VALUE "OriginalFilename", "rufus-4.9.exe"
             VALUE "ProductName", "Rufus"
-            VALUE "ProductVersion", "4.9.2254"
+            VALUE "ProductVersion", "4.9.2255"
         END
     END
     BLOCK "VarFileInfo"